Source Zendesk Support: Handle 403 Error #23035

artem1205 · 2023-02-14T22:16:45Z

What

Resolving https://github.com/airbytehq/oncall/issues/1496

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

github-actions · 2023-02-14T22:35:10Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

artem1205 · 2023-02-14T22:50:48Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4178795074

artem1205 · 2023-02-14T23:25:03Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4179007820
❌ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4179007820
🐛 https://gradle.com/s/pketyi3wkb2mg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream ticke...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 43 passed, 3 skipped in 385.60s (0:06:25) ==============

artem1205 · 2023-02-15T10:59:33Z

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4183159453
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4183159453
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      391     38    90%
source_zendesk_support/source.py        56      8    86%
--------------------------------------------------------
TOTAL                                  449     46    90%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       142      5    96%   87, 93, 242, 246-247
	 connector_acceptance_test/conftest.py                     220    102    54%   37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       134     33    75%   30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1716    348    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 391.63s (0:06:31) ===================

artem1205 · 2023-02-15T15:34:23Z

/publish connector=connectors/source-zendesk-support

🕑 Publishing the following connectors:
connectors/source-zendesk-support
https://github.com/airbytehq/airbyte/actions/runs/4185505001

Connector	Did it publish?	Were definitions generated?
connectors/source-zendesk-support	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

lazebnyi

CI jobs looks good. Let's move next to fix on-call issue. LGTM!

artem1205 · 2023-02-15T15:55:51Z

/publish connector=connectors/source-zendesk-support

🕑 Publishing the following connectors:
connectors/source-zendesk-support
https://github.com/airbytehq/airbyte/actions/runs/4185703182

Connector	Did it publish?	Were definitions generated?
connectors/source-zendesk-support	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

artem1205 · 2023-02-15T18:43:58Z

/approve-and-merge reason="Oncall 1496"

octavia-approvington · 2023-02-15T18:44:33Z

What are we doing again?

Source Zendesk Support: Handle 403 Error

fa203fd

octavia-squidington-iii added area/connectors Connector related issues connectors/source/zendesk-support labels Feb 14, 2023

Source Zendesk Support: update docs

83b7b58

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 14, 2023

Source Zendesk Support: update allowed hosts

06d4c30

artem1205 temporarily deployed to more-secrets February 14, 2023 22:27 — with GitHub Actions Inactive

Source Zendesk Support: update expected records

8e6c017

artem1205 temporarily deployed to more-secrets February 14, 2023 22:52 — with GitHub Actions Inactive

Source Zendesk Support: update expected records

2714fd5

artem1205 temporarily deployed to more-secrets February 14, 2023 23:26 — with GitHub Actions Inactive

Source Zendesk Support: update expected records

43aa584

artem1205 temporarily deployed to more-secrets February 15, 2023 11:01 — with GitHub Actions Inactive

artem1205 requested review from bazarnov and lazebnyi February 15, 2023 11:48

bazarnov approved these changes Feb 15, 2023

View reviewed changes

artem1205 temporarily deployed to more-secrets February 15, 2023 13:11 — with GitHub Actions Inactive

lazebnyi approved these changes Feb 15, 2023

View reviewed changes

Merge branch 'master' into artem1205/source-zendesk-support-OC-1496

f9e2cb1

artem1205 temporarily deployed to more-secrets February 15, 2023 15:52 — with GitHub Actions Inactive

Source Zendesk Support: update docs, bump version

6525565

artem1205 temporarily deployed to more-secrets February 15, 2023 15:57 — with GitHub Actions Inactive

auto-bump connector version

bb25838

airbyteio temporarily deployed to more-secrets February 15, 2023 16:25 — with GitHub Actions Inactive

airbyteio temporarily deployed to more-secrets February 15, 2023 17:38 — with GitHub Actions Inactive

octavia-approvington approved these changes Feb 15, 2023

View reviewed changes

octavia-approvington merged commit f93fa72 into master Feb 15, 2023

octavia-approvington deleted the artem1205/source-zendesk-support-OC-1496 branch February 15, 2023 18:44

maxi297 mentioned this pull request Mar 14, 2025

✨ Source Zendesk Support: migration posts child streams to low-code #55686

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Source Zendesk Support: Handle 403 Error #23035

Source Zendesk Support: Handle 403 Error #23035

Uh oh!

artem1205 commented Feb 14, 2023

Uh oh!

github-actions bot commented Feb 14, 2023 •

edited

Loading

Uh oh!

artem1205 commented Feb 14, 2023 •

edited by github-actions bot

Loading

Uh oh!

artem1205 commented Feb 14, 2023 •

edited by github-actions bot

Loading

Uh oh!

artem1205 commented Feb 15, 2023 •

edited by github-actions bot

Loading

Uh oh!

artem1205 commented Feb 15, 2023 •

edited by github-actions bot

Loading

Uh oh!

lazebnyi left a comment

Uh oh!

artem1205 commented Feb 15, 2023 •

edited by github-actions bot

Loading

Uh oh!

artem1205 commented Feb 15, 2023

Uh oh!

octavia-approvington commented Feb 15, 2023

Uh oh!

Uh oh!

Source Zendesk Support: Handle 403 Error #23035

Source Zendesk Support: Handle 403 Error #23035

Uh oh!

Conversation

artem1205 commented Feb 14, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Uh oh!

github-actions bot commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Airbyte Code Coverage

Uh oh!

artem1205 commented Feb 14, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artem1205 commented Feb 14, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

Uh oh!

artem1205 commented Feb 15, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

artem1205 commented Feb 15, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lazebnyi left a comment

Choose a reason for hiding this comment

Uh oh!

artem1205 commented Feb 15, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artem1205 commented Feb 15, 2023

Uh oh!

octavia-approvington commented Feb 15, 2023

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2023 •

edited

Loading

artem1205 commented Feb 14, 2023 •

edited by github-actions bot

Loading

artem1205 commented Feb 14, 2023 •

edited by github-actions bot

Loading

artem1205 commented Feb 15, 2023 •

edited by github-actions bot

Loading

artem1205 commented Feb 15, 2023 •

edited by github-actions bot

Loading

artem1205 commented Feb 15, 2023 •

edited by github-actions bot

Loading