-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: missing from configmap #22697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing from configmap #22697
Conversation
…MPARISON_NORMALIZATION_TAG from configmap helm chart
we need this PR, I have error couldn't find key STRICT_COMPARISON_NORMALIZATION_TAG in ConfigMap airbyte/airbyte-airbyte-env: CreateContainerConfigError |
Temporary solution is to use Helm chart version 0.43.29 until the issue is fixed and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this solves the problem
@xpuska513 can you review this change? |
@@ -72,4 +72,6 @@ data: | |||
WORKER_STATE_STORAGE_TYPE: {{ .Values.global.state.storage.type | quote }} | |||
SHOULD_RUN_NOTIFY_WORKFLOWS: "false" | |||
MAX_NOTIFY_WORKERS: {{ .Values.worker.maxNotifyWorkers | default "5" | quote }} | |||
STRICT_COMPARISON_NORMALIZATION_TAG: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that value is expected to be always empty?
If not, then can you please add an Values in both airbyte and airbyte-worker charts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is new, I tried to look for documentation but I had no success, I think it could be established by now
This fixed my deploy 👍 |
This was merged in airbyte-platform repo airbytehq/airbyte-platform#51 |
I got CreateContainerConfigError for airbyte-worker, with 0.44.1 |
What
Issue of missing STRICT_COMPARISON_NORMALIZATION_WORKSPACES and STRICT_COMPARISON_NORMALIZATION_TAG from configmap helm chart:
#22687
How
Add missing configs in env.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes