Skip to content

fix: missing from configmap #22697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

yuriolive
Copy link

@yuriolive yuriolive commented Feb 10, 2023

What

Issue of missing STRICT_COMPARISON_NORMALIZATION_WORKSPACES and STRICT_COMPARISON_NORMALIZATION_TAG from configmap helm chart:

#22687

How

Add missing configs in env.

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

…MPARISON_NORMALIZATION_TAG from configmap helm chart
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2023

CLA assistant check
All committers have signed the CLA.

@franviera92
Copy link
Contributor

we need this PR,

I have error

couldn't find key STRICT_COMPARISON_NORMALIZATION_TAG in ConfigMap airbyte/airbyte-airbyte-env: CreateContainerConfigError

@yuriolive
Copy link
Author

we need this PR,

I have error

couldn't find key STRICT_COMPARISON_NORMALIZATION_TAG in ConfigMap airbyte/airbyte-airbyte-env: CreateContainerConfigError

Temporary solution is to use Helm chart version 0.43.29 until the issue is fixed and merged.

Copy link
Contributor

@franviera92 franviera92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solves the problem

@marcosmarxm
Copy link
Member

@xpuska513 can you review this change?

@@ -72,4 +72,6 @@ data:
WORKER_STATE_STORAGE_TYPE: {{ .Values.global.state.storage.type | quote }}
SHOULD_RUN_NOTIFY_WORKFLOWS: "false"
MAX_NOTIFY_WORKERS: {{ .Values.worker.maxNotifyWorkers | default "5" | quote }}
STRICT_COMPARISON_NORMALIZATION_TAG: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that value is expected to be always empty?
If not, then can you please add an Values in both airbyte and airbyte-worker charts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new, I tried to look for documentation but I had no success, I think it could be established by now

@CODY-RAY
Copy link

This fixed my deploy 👍

@c-p-b
Copy link

c-p-b commented Feb 21, 2023

This was merged in airbyte-platform repo airbytehq/airbyte-platform#51

@sajarin sajarin closed this Mar 1, 2023
@jovezhong
Copy link
Contributor

I got CreateContainerConfigError for airbyte-worker, with 0.44.1
neee to wait for the next release of helm chart, or use 0.43.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants