Allow users to cancel a currently running sync on a disabled connection #22241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizel852
approved these changes
Feb 3, 2023
edmundito
suggested changes
Feb 6, 2023
airbyte-webapp/src/pages/connections/ConnectionStatusPage/ConnectionStatusPage.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/pages/connections/ConnectionStatusPage/ConnectionStatusPage.module.scss
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/pages/connections/ConnectionStatusPage/ConnectionStatusPage.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/pages/connections/ConnectionStatusPage/ConnectionStatusPage.tsx
Show resolved
Hide resolved
- Changed logic to show/hide action buttons for Connections Status Page
m19berger
force-pushed
the
mark/allow-users-to-cancel_a-currently-running-sync-on-a-disabled-connection
branch
from
0e4d1b5 to
3812186
Compare
- Changed logic to show/hide action buttons for Connections Status Page
edmundito
approved these changes
Feb 6, 2023
m19berger
deleted the
mark/allow-users-to-cancel_a-currently-running-sync-on-a-disabled-connection
branch
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #22084
How
Changed logic to show/hide action buttons for the Connections Status Page
Now users have the possibility to cancel sync with a
disabledconnectionLoom
https://www.loom.com/share/bcb3f306ca6745ffbc2dab84fa570ffe