🪟 🐛 Add cloudPublicApiUrl into webapp env #22229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykmh
changed the title
terencecho
approved these changes
Feb 1, 2023
|
I'm curious why we didn't notice any error messages since your previous PR contained a block to throw an error if that var was missing. |
@terencecho the errors are only thrown (and handled, with an error message) at run-time in the browser. You can see some of the datadog RUM errors logged here: We currently don't have any alerts set up for this, but I will do that now. |
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
During the config refactor we removed the default
cloudPublicApiUrlvalue, but did not add a value to.env. This PR adds the value to.envso thatREACT_APP_CLOUD_API_URLis defined during the build step.