Set sync_mode as incremental instead of full refresh in catalog speci… #22183
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fying incremental sync
|
|
octavia-squidington-iv
added
the
area/documentation
sergio-ropero
approved these changes
Feb 2, 2023
prateekmukhedkar
deleted the
prateekmukhedkar/fix-adding-incremental-connector
branch
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…fying incremental sync (airbytehq#22183) Co-authored-by: prateekmukhedkar <[email protected]>
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set sync_mode as incremental instead of full refresh in incremental catalog.
What
Fix
sync_modeparameters inincremental_configured_catalog.jsonso that source does an incremental sync instead of full refresh.How
This change simply updates
incremental_configured_catalog.jsonwith the correct value forsync_modeso that an incremental sync is done. There are no changes needed in source.py.Verified the changes by running the following command which is present in the adding incremental sync to source tutorial and seeing that new state gets printed:
python source.py read --config secrets/valid_config.json --catalog incremental_configured_catalog.json --state state.jsonRecommended reading order
build-a-connector-the-hard-way.mdadding-incremental-sync.md🚨 User Impact 🚨
Users following the guide will be able to complete the tutorial on how to add incremental sync when building source connectors.