-
Notifications
You must be signed in to change notification settings - Fork 4.6k
🪟 🔧 Switch to pnpm
for package managing
#22053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 9 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
fd225c9
WIP
9b1d50b
Merge branch 'master' into tim/pnpm
35bf80e
WIP
0a164df
Merge branch 'master' into tim/pnpm
63001be
Adjust lockfile
2dab133
Fix issues
ff69510
Adjust github flows
d361c06
More fixes
07b0b0b
Adjust documentation
b3649dc
Remove unnecessary tsconfig entry
2d1698b
Merge branch 'master' into tim/pnpm
ca66b4c
Cleanup .eslintrc
3604bdc
Update dependencies
99ef8d1
Fix more issues
6d0b4e2
Correct TS
e08d8cf
Make pnpm install run always via gradle
cdf5328
Install @storybook/react explicitaly
31edfdc
Update snapshots due to new libraries
09cb556
Add node-fetch types
6c2ff39
Add `url` package
352a21a
Freeze react router version (due to useBlocker)
e851a1c
Merge branch 'master' into tim/pnpm
695cdb6
Fix typing issue
3791796
Update airbyte-webapp/src/components/ui/BarChart/BarChart.tsx
3bfc186
Rewrite README
ab1d27f
Merge branch 'master' into tim/pnpm
8d2cc0a
Update e2e test library
a7dd7b9
Remove retry
9862222
Latest pnpm version
d4feec3
Revert removal of retry logic
f0e25f3
Merge branch 'master' into tim/pnpm
5db4ad5
Merge branch 'master' into tim/pnpm
bf1da86
Merge branch 'master' into tim/pnpm
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
engine-strict=true | ||
enable-pre-post-scripts=true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,46 @@ | ||
plugins { | ||
id "base" | ||
id "com.github.node-gradle.node" version "3.3.0" | ||
id "com.github.node-gradle.node" version "3.4.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ℹ️ Required to have |
||
} | ||
|
||
// Use the node version that's defined in the .nvmrc file | ||
def nodeVersion = new File("${projectDir}/.nvmrc").text.trim(); | ||
|
||
// Read pnpm version to use from package.json engines.pnpm entry | ||
def pnpmVer = new groovy.json.JsonSlurper().parse(new File("${projectDir}/package.json")).engines.pnpm.trim(); | ||
|
||
// This array should contain a path to all configs that are common to most build tasks and | ||
// might affect them (i.e. if any of those files change we want to rerun most tasks) | ||
def commonConfigs = [ | ||
'.env', | ||
'package.json', | ||
'package-lock.json', | ||
'pnpm-lock.yaml', | ||
'tsconfig.json', | ||
'.prettierrc.js' | ||
] | ||
|
||
node { | ||
download = true | ||
version = nodeVersion | ||
npmInstallCommand = 'ci' | ||
pnpmVersion = pnpmVer | ||
} | ||
|
||
task validateLockFiles { | ||
description "Validate only a pnpm-lock.yaml lock file exists" | ||
doLast { | ||
assert file("pnpm-lock.yaml").exists() | ||
assert !file("package-lock.json").exists() | ||
assert !file("yarn.lock").exists() | ||
} | ||
} | ||
|
||
npm_run_build { | ||
pnpmInstall.dependsOn validateLockFiles | ||
|
||
task pnpmBuild(type: PnpmTask) { | ||
dependsOn pnpmInstall | ||
|
||
args = ['build'] | ||
|
||
inputs.files commonConfigs | ||
inputs.file '.eslintrc.js' | ||
inputs.dir 'public' | ||
|
@@ -40,7 +58,7 @@ task test(type: NpmTask) { | |
} | ||
|
||
task licenseCheck(type: NpmTask) { | ||
dependsOn npmInstall | ||
dependsOn pnpmInstall | ||
|
||
args = ['run', 'license-check'] | ||
inputs.files commonConfigs | ||
|
@@ -52,7 +70,7 @@ task licenseCheck(type: NpmTask) { | |
} | ||
|
||
task validateLinks(type: NpmTask) { | ||
dependsOn npmInstall | ||
dependsOn pnpmInstall | ||
|
||
args = ['run', 'validate-links'] | ||
|
||
|
@@ -62,7 +80,7 @@ task validateLinks(type: NpmTask) { | |
} | ||
|
||
task buildStorybook(type: NpmTask) { | ||
dependsOn npmInstall | ||
dependsOn pnpmInstall | ||
args = ['run', 'build:storybook'] | ||
|
||
inputs.files commonConfigs | ||
|
@@ -74,7 +92,7 @@ task buildStorybook(type: NpmTask) { | |
} | ||
|
||
task copyBuildOutput(type: Copy) { | ||
dependsOn copyDocker, npm_run_build | ||
dependsOn copyDocker, pnpmBuild | ||
|
||
from "${project.projectDir}/build/app" | ||
into 'build/docker/bin/build' | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Required for
pnpm
to execute theprestart
etc scripts. It doesn't do so by default, but we're using the heavily for Orval compilation.