Skip to content

Turn off default httpavailabilitystrategy for source-intercom (GA) #22010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2023
Merged

Turn off default httpavailabilitystrategy for source-intercom (GA) #22010

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c51ca1
Turn off default for source-intercom (GA)
erohmensing Jan 25, 2023
f7e0fea
Update source.py
erohmensing Jan 27, 2023
4bf3d40
Update intercom.md
erohmensing Jan 27, 2023
dd18da5
auto-bump connector version
octavia-squidington-iii Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-intercom/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ COPY source_intercom ./source_intercom
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.29
LABEL io.airbyte.version=0.1.30
LABEL io.airbyte.name=airbyte/source-intercom
5 changes: 5 additions & 0 deletions airbyte-integrations/connectors/source-intercom/source_intercom/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from airbyte_cdk.logger import AirbyteLogger
from airbyte_cdk.sources import AbstractSource
from airbyte_cdk.sources.streams import Stream
from airbyte_cdk.sources.streams.availability_strategy import AvailabilityStrategy
from airbyte_cdk.sources.streams.http import HttpStream
from airbyte_cdk.sources.streams.http.requests_native_auth import TokenAuthenticator
from requests.auth import AuthBase
Expand Down Expand Up @@ -42,6 +43,10 @@ def authenticator(self):
return self._session.auth
return super().authenticator

@property
def availability_strategy(self) -> Optional["AvailabilityStrategy"]:
return None

def next_page_token(self, response: requests.Response, **kwargs) -> Optional[Mapping[str, Any]]:
"""
Abstract method of HttpStream - should be overwritten.
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/intercom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ The Intercom connector should not run into Intercom API limitations under normal
## Changelog

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :-------------------------------------------------------------------------------------------- |
|:--------| :--------- | :------------------------------------------------------- | :-------------------------------------------------------------------------------------------- |
| 0.1.30 | 2023-01-27 | [22010](https://github.com/airbytehq/airbyte/pull/22010) | Set `AvailabilityStrategy` for streams explicitly to `None` |
| 0.1.29 | 2022-10-31 | [18681](https://github.com/airbytehq/airbyte/pull/18681) | Define correct version for airbyte-cdk~=0.2 |
| 0.1.28 | 2022-10-20 | [18216](https://github.com/airbytehq/airbyte/pull/18216) | Use airbyte-cdk~=0.2.0 with SQLite caching |
| 0.1.27 | 2022-08-28 | [17326](https://github.com/airbytehq/airbyte/pull/17326) | Migrate to per-stream states. |
Expand Down