Skip to content

🪟Auto detect schema: Remove backdrop on non-breaking change, add toast on no refresh #21998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2023
Merged

🪟Auto detect schema: Remove backdrop on non-breaking change, add toast on no refresh #21998

merged 4 commits into from
Jan 30, 2023

Conversation

edmundito
Copy link
Contributor

What

This updates a couple of areas based on feedback on the feature:

  • Removes the backdrop that blocks the connection from being edited, at least for now. Users are still warned that the schema has changed and they will now be allowed to take the risk of updating the replication settings
  • When the schema is refreshed, and there are no updates, it will notify the user with a toast. Additionally, the status of the schema update is updated.

How

  • Removes logic
  • For showing the toast, the connection is now updated with the refreshed schema change in case the state is no longer the previous state, so the auto-detect schema warnings can disappear after a refresh.

@edmundito edmundito self-assigned this Jan 27, 2023
@edmundito edmundito requested a review from teallarson January 27, 2023 19:35
@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 27, 2023
@edmundito edmundito requested a review from dizel852 January 30, 2023 15:30
dizel852
dizel852 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested locally - works as expected

teallarson
teallarson approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@edmundito edmundito merged commit 786e04f into master Jan 30, 2023
@edmundito edmundito deleted the edmundito/update-auto-detect-logic branch January 30, 2023 18:19
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizel852 dizel852 dizel852 approved these changes

@teallarson teallarson teallarson approved these changes

Assignees

@edmundito edmundito

Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundito @dizel852 @teallarson @octavia-squidington-iv