-
Notifications
You must be signed in to change notification settings - Fork 4.6k
cloud-availability-updater: implement git interactions #21976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-availability-updater: implement git interactions #21976
Conversation
e711f2f
to
18abf99
Compare
Airbyte Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love code that writes code!
Are there any special permissions you will need to run this on GH actions?
logging.warning(f"{connector.connector_name}'s definition id is already in {definitions_mask_path}.") | ||
return None | ||
|
||
to_append = f"""# {connector.connector_name} (from cloud availability updater) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I understand how this will have all the YAML properties form the OSS repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need the connector definition id to add it to the mask.
But we usually comment the name of the connector . e.g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! We should add a note in the PR that this creates then about "...and if you you want to modify the connector (e.g. resourceRequirements) do so before merging this PR"
documentation_is_available=True | ||
) | ||
cloud_availability_updater.deploy_new_connector_to_cloud_repo(repo_path, airbyte_cloud_repo, connector) | ||
new_branch_name = f"cloud-availability-updater/deploy-{connector.connector_technical_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 connector names shouldn't have any spaces or special chars
710dcbe
to
18abf99
Compare
|
@alafanechere as long as you can commit code you can access secrets which is the only real barrier to GH actions. they keys mostly have the same permissions, but there are some edge cases I think most keys are basically users. there are a couple that own the org. If you see a permissions error I think the error message is pretty clear |
What
Starts the work on https://github.com/airbytehq/airbyte-cloud/issues/4213
We want to automatically open PRs when a connectors becomes eligible to cloud.
This PR focuses on git interaction logics. PR creation and actual call to the new
deploy_new_connector_to_cloud_repo
will be done in future PRs.Prior work:
Future works:
airbyte-cloud
to run the Cloud Availability updater daily. (cf Cloud Availability Updater: bootstrap it #21918)How
Implement the logic to:
airbyte-cloud
repoRecommended reading order
airbyte/tools/ci_connector_ops/ci_connector_ops/qa_engine/cloud_availability_updater.py
Line 24 in 18abf99
airbyte/tools/ci_connector_ops/tests/test_qa_engine/test_cloud_availability_updater.py
Line 43 in 18abf99
🚨 User Impact 🚨
None, the code implemented is not actually called at the moment.