🪟 🧹 Stream details panel text cols should be equal width #21810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YatsukBogdan1
approved these changes
Jan 25, 2023
set equal width for source and destination field names;
edmundito
approved these changes
Jan 27, 2023
| } | ||
|
|
||
| .dataTypeCell { | ||
| @extend %bodyCell; | ||
|
|
||
| width: $cell-fixed-width; |
There was a problem hiding this comment.
The data type cell should maybe have a min-width and max-width. The max width should be up to 200px or so to fit the new data types introduced in #21757 (notably Timestamp With Timezone)
There was a problem hiding this comment.
Double-checked: if 100px is not enough - the cell will grow to fit the content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #20454
UPD: I've updated the PR since the first implementation wasn't satisfied the requirements.
https://www.loom.com/share/6e9c63f8ab3541f7a9201d6bc2428171
How
Set range width for text cells(Source and Destination field names).
For other cells - set min-width: why not static width? - it looks nicer when we zoom out.