Skip to content

🎉 New Source: Railz #20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 149 commits into from
Feb 23, 2023
Merged

🎉 New Source: Railz #20960

merged 149 commits into from
Feb 23, 2023

Conversation

Allexik
Copy link
Contributor

@Allexik Allexik commented Jan 3, 2023

What

Issue: #17604
Added new source for railz.ai

How

In low-code

Recommended reading order

  1. railz_ai.yaml
  2. y.python

Pre-merge Checklist

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023

CLA assistant check
All committers have signed the CLA.

@lazebnyi
Copy link
Collaborator

lazebnyi commented Jan 3, 2023

Have you added all the items according to the checklist from the PR body?

@lazebnyi
Copy link
Collaborator

lazebnyi commented Jan 3, 2023

Why didn't you run the tests?

@Allexik
Copy link
Contributor Author

Allexik commented Jan 3, 2023

Why didn't you run the tests?

tests are in the description (Tests / Integration & Acceptance)

@lazebnyi
Copy link
Collaborator

lazebnyi commented Jan 3, 2023

Plz run test in the PR.

@Allexik
Copy link
Contributor Author

Allexik commented Jan 3, 2023

/test connector=connectors/source-railz-ai

🕑 connectors/source-railz-ai https://github.com/airbytehq/airbyte/actions/runs/3829841239
❌ connectors/source-railz-ai https://github.com/airbytehq/airbyte/actions/runs/3829841239
🐛 https://gradle.com/s/xujydwgrbloma

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestSpec::test_config_match_spec[inputs0] - FileNotFoundE...
ERROR test_core.py::TestConnection::test_check[inputs0] - FileNotFoundError: ...
ERROR test_core.py::TestDiscovery::test_discover[inputs0] - FileNotFoundError...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - Fil...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - Fil...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_read[inputs2] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_read[inputs3] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_read[inputs4] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs0]
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs1]
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs2]
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs3]
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs4]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs2]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs3]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs4]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs2]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs3]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs1]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs2]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs3]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs1]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs2]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs3]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:97: The previous connector image could not be retrieved.
================== 13 passed, 1 skipped, 38 errors in 55.55s ===================

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 3, 2023
@Allexik Allexik temporarily deployed to more-secrets January 3, 2023 14:21 — with GitHub Actions Inactive
@Allexik Allexik temporarily deployed to more-secrets January 3, 2023 14:21 — with GitHub Actions Inactive
@Allexik Allexik temporarily deployed to more-secrets January 3, 2023 14:54 — with GitHub Actions Inactive
@Allexik Allexik temporarily deployed to more-secrets January 3, 2023 14:54 — with GitHub Actions Inactive
@Allexik Allexik temporarily deployed to more-secrets January 3, 2023 16:35 — with GitHub Actions Inactive
@Allexik Allexik temporarily deployed to more-secrets January 3, 2023 16:35 — with GitHub Actions Inactive
@Allexik Allexik temporarily deployed to more-secrets January 4, 2023 22:13 — with GitHub Actions Inactive
@lazebnyi
Copy link
Collaborator

lazebnyi commented Feb 22, 2023

@grubberr I believe Add labels to github PRs based on context failed related to who is author of PR.

And I think we can move next for this PR after icon update, because required builds are passed. @YowanR WDYT?

@grubberr
Copy link
Contributor

grubberr commented Feb 23, 2023

/test connector=connectors/source-railz

🕑 connectors/source-railz https://github.com/airbytehq/airbyte/actions/runs/4250368869
✅ connectors/source-railz https://github.com/airbytehq/airbyte/actions/runs/4250368869
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_railz/__init__.py         2      0   100%
source_railz/source.py           4      1    75%
source_railz/components.py      80     20    75%
------------------------------------------------
TOTAL                           86     21    76%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       142      5    96%   87, 93, 242, 246-247
	 connector_acceptance_test/conftest.py                     220    102    54%   37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       134     33    75%   30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1716    348    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 1587.43s (0:26:27) ==================

@grubberr grubberr removed area/documentation Improvements or additions to documentation area/connectors Connector related issues bounty connectors/source/railz labels Feb 23, 2023
@grubberr grubberr added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 23, 2023
@grubberr
Copy link
Contributor

grubberr commented Feb 23, 2023

/publish connector=connectors/source-railz

🕑 Publishing the following connectors:
connectors/source-railz
https://github.com/airbytehq/airbyte/actions/runs/4255350160


Connector Did it publish? Were definitions generated?
connectors/source-railz

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor

grubberr commented Feb 23, 2023

This CI check can be ignored "Add Labels to PRs. Safe to Merge on fail"

Screenshot 2023-02-23 at 22 33 54

@grubberr grubberr merged commit 645558b into master Feb 23, 2023
@grubberr grubberr deleted the oleksandr/new-connector-railz-ai branch February 23, 2023 20:34
@alafanechere
Copy link
Contributor

It's now on cloud 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty connectors/source/railz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Source: Railz