Skip to content

Only add definitions updater cron when enabled #20838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Only add definitions updater cron when enabled #20838

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea19816
Only add definitions updater cron when enabled
gosusnp Dec 22, 2022
b3b0e7f
Remove unused property
gosusnp Dec 22, 2022
e99f84c
Merge branch 'master' into gosusnp/only-enable-destination-cron-when-…
gosusnp Jan 3, 2023
213c11f
Merge branch 'master' into gosusnp/only-enable-destination-cron-when-…
gosusnp Jan 3, 2023
972b74c
Merge branch 'master' into gosusnp/only-enable-destination-cron-when-…
gosusnp Jan 3, 2023
5da6b5f
Merge branch 'master' into gosusnp/only-enable-destination-cron-when-…
gosusnp Jan 3, 2023
2846e5f
Merge branch 'master' into gosusnp/only-enable-destination-cron-when-…
gosusnp Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions airbyte-cron/src/main/java/io/airbyte/cron/selfhealing/DefinitionsUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.airbyte.config.init.ApplyDefinitionsHelper;
import io.airbyte.config.init.RemoteDefinitionsProvider;
import io.airbyte.config.persistence.ConfigRepository;
import io.micronaut.context.annotation.Requires;
import io.micronaut.context.annotation.Value;
import io.micronaut.scheduling.annotation.Scheduled;
import jakarta.inject.Singleton;
Expand All @@ -25,36 +26,29 @@
*/
@Singleton
@Slf4j
@Requires(property = "airbyte.cron.update-definitions.enabled",
value = "true")
public class DefinitionsUpdater {

private final ConfigRepository configRepository;

private final boolean shouldUpdateDefinitions;

private final URI remoteCatalogUrl;
private final DeploymentMode deploymentMode;

public DefinitionsUpdater(final ConfigRepository configRepository,
final DeploymentMode deploymentMode,
@Value("${airbyte.remote-connector-catalog-url}") final String remoteCatalogUrl,
@Value("${airbyte.cron.update-definitions.enabled}") final boolean shouldUpdateDefinitions) {
@Value("${airbyte.remote-connector-catalog-url}") final String remoteCatalogUrl) {
log.info("Creating connector definitions updater");

this.configRepository = configRepository;
this.deploymentMode = deploymentMode;
this.remoteCatalogUrl = remoteCatalogUrl != null ? URI.create(remoteCatalogUrl) : null;
this.shouldUpdateDefinitions = shouldUpdateDefinitions;
}

@Trace(operationName = SCHEDULED_TRACE_OPERATION_NAME)
@Scheduled(fixedRate = "30s",
initialDelay = "1m")
void updateDefinitions() {
if (!shouldUpdateDefinitions) {
log.info("Connector definitions update disabled.");
return;
}

if (remoteCatalogUrl == null) {
log.warn("Tried to update definitions, but the remote catalog url is not set");
return;
Expand Down