Skip to content

🪟 🧹 Use custom arrow icon in the new Streams Table #20678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 3, 2023
Merged

🪟 🧹 Use custom arrow icon in the new Streams Table #20678

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65e4020
update icon used in streams table and its headers
teallarson Dec 19, 2022
bda7f7e
Merge branch 'master' into teal/arrow-icon-update
teallarson Jan 3, 2023
1d15bec
Merge branch 'master' into teal/arrow-icon-update
teallarson Jan 3, 2023
21a0c6c
wrap in arrowCell div
teallarson Jan 3, 2023
2b13ef2
Merge branch 'master' into teal/arrow-icon-update
teallarson Jan 3, 2023
7fd57ca
Merge branch 'master' into teal/arrow-icon-update
teallarson Jan 3, 2023
a32f87c
Merge branch 'master' into teal/arrow-icon-update
teallarson Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions airbyte-webapp/src/components/connection/CatalogTree/next/CatalogTreeTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { faArrowRight } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import classnames from "classnames";
import React, { useMemo } from "react";
import { FormattedMessage } from "react-intl";

import { ArrowRightIcon } from "components/icons/ArrowRightIcon";
import { Cell, Row } from "components/SimpleTableComponents";
import { CheckBox } from "components/ui/CheckBox";
import { Switch } from "components/ui/Switch";
Expand Down Expand Up @@ -119,7 +118,7 @@ export const CatalogTreeTableRow: React.FC<StreamHeaderProps> = ({
/>
)}
</Cell>
<FontAwesomeIcon icon={faArrowRight} className={styles.arrowCell} />
<ArrowRightIcon />
<Cell flex={1} title={destNamespace}>
<Text size="md" className={styles.cellText}>
{destNamespace}
Expand Down
5 changes: 2 additions & 3 deletions airbyte-webapp/src/components/connection/CatalogTree/next/StreamConnectionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { faArrowRight } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import classnames from "classnames";
import { FormattedMessage } from "react-intl";

import { ArrowRightIcon } from "components/icons/ArrowRightIcon";
import { Heading } from "components/ui/Heading";

import { useConnectionFormService } from "hooks/services/ConnectionForm/ConnectionFormService";
Expand Down Expand Up @@ -31,7 +30,7 @@ export const StreamConnectionHeader: React.FC = () => {
</Heading>
</div>
<div className={styles.arrowContainer}>
<FontAwesomeIcon icon={faArrowRight} />
<ArrowRightIcon />
</div>
<div className={destinationStyles}>
{renderIcon(destinationDefinition.icon)}{" "}
Expand Down