Skip to content

🪟 🔧 Add testid to error view #20095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2022
Merged

🪟 🔧 Add testid to error view #20095

merged 3 commits into from
Dec 5, 2022

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Dec 5, 2022

What

Adds a data-testid to the "Oops" error view. This allows us to filter on it's appearance in Fullstory to better investigate those errors.

@timroes timroes added the area/frontend Related to the Airbyte webapp label Dec 5, 2022
@timroes timroes requested a review from a team as a code owner December 5, 2022 20:16
@octavia-squidington-iv octavia-squidington-iv added the area/platform issues related to the platform label Dec 5, 2022
krishnaglick
krishnaglick approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, did not test locally.

@timroes timroes merged commit 6b39a1a into master Dec 5, 2022
@timroes timroes deleted the tim/errorview-testid branch December 5, 2022 22:11
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @krishnaglick @octavia-squidington-iv