🪟 🔧 Generify GroupControls to make it more reusable #20004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
lmossman
commented
Dec 1, 2022
| @@ -6,7 +6,6 @@ $group-spacing: variables.$spacing-xl; | |||
| $border-width: variables.$border-thick; | |||
|
|
|||
| .container { | |||
| margin-bottom: 27px; | |||
There was a problem hiding this comment.
Removed this because we don't want this spacing in the Connector Builder. To not affect the look of the ConnectorForm, I opted to wrap the ArraySection and ConditionSection components in SectionContainers instead: https://github.com/airbytehq/airbyte/pull/20004/files#diff-359ca8d25eceab9f588e4ca17095865f532588fecd0d7d9f2fc76458c1b1f10bR66
This is similar to how we add the correct spacing in FormSection
flash1293
approved these changes
Dec 2, 2022
|
|
||
| .dropdown { | ||
| margin-left: auto; | ||
| padding: 0 2px; |
There was a problem hiding this comment.
nit: should we use a size variable here?
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Connector Builder needs to include inputs similar to the ConditionSection of the ConnectorForm, in which there is a label with a dropdown to select which fields are shown inside of the box. However, the styling and positioning of the dropdown is currently contained in the
ConditionSectioncomponent, which has other assumptions and logic specific to the ConnectorForm.How
Instead, we would like to reuse the generic GroupControls component to implement this in the connector builder, so to avoid repeating the dropdown styling, this PR makes the label and dropdown explicit props, rather than taking in a single
titleprop that contains both, and moves the styling of these into the GroupControls scss file.This way, the Connector Builder can reuse the GroupControls component to get the same look as that in the ConnectorForm, without needing to repeat styling, such as in this feature branch.
🚨 User Impact 🚨
There should be no user-visible changes as a result of this PR.