🪟 🎉 Display service token validation errors in the UI #19578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
timroes
previously requested changes
Nov 18, 2022
airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.tsx
Outdated
Show resolved
Hide resolved
ambirdsall
commented
Nov 18, 2022
| onError: (e) => { | ||
| setHasValidationError(true); | ||
|
|
||
| setValidationMessage(e.message.replace("Internal Server Error: ", "")); |
There was a problem hiding this comment.
Here is the issue for the status code cleanup.
|
I also added a success message; to keep the review workflow as simple as possible for this PR, I put that commit into a separate PR. |
ambirdsall
force-pushed
the
alex/validate-dbt-cloud-service-tokens
branch
from
6a5c8a5 to
b66a72d
Compare
lmossman
approved these changes
Nov 18, 2022
ambirdsall
force-pushed
the
alex/validate-dbt-cloud-service-tokens
branch
from
ee53f98 to
7ca93f9
Compare
ambirdsall
dismissed
timroes’s stale review
All requested changes were addressed; dismissing so waking Tim up is not a blocker for merging before holiday code freeze
Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.
* Clean up type definitions
Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.
* Show success message and clear form on successful dbt cloud token submission
* Always clear form error state and message in sync
* Disallow deleting jobs while an update is pending
ambirdsall
force-pushed
the
alex/validate-dbt-cloud-service-tokens
branch
from
0963cf2 to
bab76fb
Compare
This was referenced Nov 21, 2022
SofiiaZaitseva
pushed a commit
that referenced
this pull request
Nov 24, 2022
Note: the backend returns a 500 status (should be 400, or at least 4xx), so the frontend has to remove the error message's unsightly "Internal Server Error: " prefix in post. In the future, we want to move this to a 400 error.
letiescanciano
added a commit
that referenced
this pull request
Nov 28, 2022
* master: (74 commits) Fix support icon in sidebar fix: add BuildPulse report for helm ac tests (#19785) fix: yaml syntax (#19775) 🪟 🐛 Fix custom connection creation endpoint (#19702) Source facebook marketing: check "breakdowns" combinations (#19645) fix typo: notify instead of sync (#19737) find_non_rate_limited_PAT (#19736) Source Google Ads: fix schema for "campaigns" stream (#19700) 🎉 Source Asana: migrate to new SAT, added base HTTP errors handling (#19561) fix order not to randomly fail backward compatibility check (#19377) Bump helm chart version reference to 0.42.0 (#19706) fix: add extraEnv block (#19703) Bump Airbyte version from 0.40.21 to 0.40.22 (#19687) Bump helm chart version reference to 0.41.3 (#19685) Add connector builder server to airbyte proxy, kube overlays, and helm charts (#19554) dbt Cloud integration doc (#19619) 🪟 🎉 Display service token validation errors in the UI (#19578) 17644 Update Destination data type test to use the new data types (#19281) Docs: fix broken connector builder UI docs links (#19631) Bump Airbyte version from 0.40.20 to 0.40.21 (#19634) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Shows error state if backend's token validation fails.
Two issues:
I ran into a silly type error (default type forI figured out the issue; while I'm not sure why my valid call toonErrorisunknown, which didn't let me access its argument'smessageproperty without a wholeas anysong-and-dance, including a linter magic comment 😢. There's a comment with a bit more detail.useMutationwasn't typechecking, adding aMutationIdargument does, which lets me clean up the call site in the settings component."Internal Server Error: "prefix in post (cc @mfsiega-airbyte)