Skip to content

🪟 🔧 Move 'Example values' into intl #19446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022
Merged

🪟 🔧 Move 'Example values' into intl #19446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-webapp/src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,7 @@
"connector.connectorsInDevelopment.docLink": "See our <lnk>documentation</lnk> for more details.",
"connector.setupGuide": "Setup Guide",
"connector.setupGuide.notFound": "No Setup Guide found for this connector.",
"connector.exampleValues": "Example {count, plural, one {value} other {values}}",

"credits.credits": "Credits",
"credits.whatAreCredits": "What are credits?",
Expand Down
5 changes: 4 additions & 1 deletion airbyte-webapp/src/views/Connector/ConnectorForm/components/Property/LabelInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { JSONSchema7Type } from "json-schema";
import React from "react";
import { FormattedMessage } from "react-intl";

import { TextWithHTML } from "components/ui/TextWithHTML";

Expand Down Expand Up @@ -35,7 +36,9 @@ const Examples: React.FC<Pick<LabelInfoProps, "examples">> = ({ examples }) => {
return (
<div>
{/* don't use <Text as=h4> here, because we want the default parent styling for this header */}
<h4 className={styles.exampleHeader}>{`Example value${examplesArray.length > 1 ? "s" : ""}`}</h4>
<h4 className={styles.exampleHeader}>
<FormattedMessage id="connector.exampleValues" values={{ count: examplesArray.length }} />
</h4>
<div className={styles.exampleContainer}>
{examplesArray.map((example) => (
<span className={styles.exampleItem}>{example}</span>
Expand Down