[888]Destination-Bigquery: fixed check method to capture mismatch dataset location #19358

etsybaev · 2022-11-11T18:36:28Z

What

The check connection method doesn't catch a case when the existing's dataset location doesn't match to the location set in airbyte connection config. Identified issue through this Stackoverflow post

Later on sync it fails with that error:

POST https://www.googleapis.com/upload/bigquery/v2/projects/dataline-integration-testing/jobs?uploadType=resumable
{
  "error": {
    "code": 404,
    "message": "Not found: Dataset integration-testing:test",
    "errors": [
      {
        "message": "Not found: Dataset integration-testing:test",
        "domain": "global",
        "reason": "notFound"
      }
    ],
    "status": "NOT_FOUND"
  }
}

How

Updated check method to check the location as well. Tested locally.

Tested locally with dev image
Passes when locations are same:

Fails when locations are different:

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…aset location

etsybaev · 2022-11-11T18:37:04Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3447221027
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3447221027
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

ryankfu

LGTM, for context this fixes a mismatched dataset location identified in https://github.com/airbytehq/oncall/issues/888

github-actions · 2022-11-11T18:37:47Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

⚠ Destinations (2)

Connector	Version	Changelog	Publish
`destination-bigquery`	`1.2.7`	✅	✅
`destination-bigquery-denormalized`	`1.2.7`	⚠ (doc not found)	✅

See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

ryankfu · 2022-11-11T18:39:10Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3447232710
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3447232710
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-11-11T19:29:18Z

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/3447502239

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

etsybaev · 2022-11-11T20:24:13Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 Publishing the following connectors:
connectors/destination-bigquery-denormalized
https://github.com/airbytehq/airbyte/actions/runs/3447776557

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery-denormalized	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…aset location (#19358) * [888]Destination-Bigquery: fixed check method to capture mismatch dataset location

[888]Destination-Bigquery: fixed check method to capture mismatch dat…

bfb5c68

…aset location

etsybaev requested a review from ryankfu November 11, 2022 18:36

octavia-squidington-iv added area/connectors Connector related issues connectors/destination/bigquery labels Nov 11, 2022

ryankfu approved these changes Nov 11, 2022

View reviewed changes

etsybaev marked this pull request as ready for review November 11, 2022 18:37

etsybaev added 3 commits November 11, 2022 19:45

fix checkstyle

86b1d90

fix getOrCreateMethod

5f24d13

Bumped version

7b2e7a3

octavia-squidington-iv added area/documentation Improvements or additions to documentation connectors/destination/bigquery-denormalized labels Nov 11, 2022

auto-bump connector version

9bf3e83

octavia-squidington-iii temporarily deployed to more-secrets November 11, 2022 20:24 Inactive

auto-bump connector version

d414381

octavia-squidington-iii temporarily deployed to more-secrets November 11, 2022 21:05 Inactive

etsybaev merged commit 6640a47 into master Nov 11, 2022

etsybaev deleted the etsybaev/destination-bigquery-fix-check-location-method branch November 11, 2022 21:07

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

akashkulk pushed a commit that referenced this pull request Dec 2, 2022

[888]Destination-Bigquery: fixed check method to capture mismatch dat…

bb69670

…aset location (#19358) * [888]Destination-Bigquery: fixed check method to capture mismatch dataset location

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[888]Destination-Bigquery: fixed check method to capture mismatch dataset location #19358

[888]Destination-Bigquery: fixed check method to capture mismatch dataset location #19358

Uh oh!

etsybaev commented Nov 11, 2022 •

edited by ryankfu

Loading

Uh oh!

etsybaev commented Nov 11, 2022 •

edited by github-actions bot

Loading

Uh oh!

ryankfu left a comment •

edited

Loading

Uh oh!

github-actions bot commented Nov 11, 2022 •

edited

Loading

✅ Sources (0)

⚠ Destinations (2)

Actionable Items

Uh oh!

ryankfu commented Nov 11, 2022 •

edited by github-actions bot

Loading

Uh oh!

etsybaev commented Nov 11, 2022 •

edited by github-actions bot

Loading

Uh oh!

etsybaev commented Nov 11, 2022 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

[888]Destination-Bigquery: fixed check method to capture mismatch dataset location #19358

[888]Destination-Bigquery: fixed check method to capture mismatch dataset location #19358

Uh oh!

Conversation

etsybaev commented Nov 11, 2022 • edited by ryankfu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

Uh oh!

etsybaev commented Nov 11, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

ryankfu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Affected Connector Report

✅ Sources (0)

⚠ Destinations (2)

Actionable Items

Uh oh!

ryankfu commented Nov 11, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

etsybaev commented Nov 11, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

etsybaev commented Nov 11, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

etsybaev commented Nov 11, 2022 •

edited by ryankfu

Loading

etsybaev commented Nov 11, 2022 •

edited by github-actions bot

Loading

ryankfu left a comment •

edited

Loading

github-actions bot commented Nov 11, 2022 •

edited

Loading

ryankfu commented Nov 11, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 11, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 11, 2022 •

edited by github-actions bot

Loading