Only persist secrets if we hydrated them in workspace webhook config handling #19352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
joeykmh
reviewed
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Only persist secrets if we actually ever hydrated/read them in the webhook config handling.
Today, we always write the workspace via the SecretsRepositoryWriter (which always splits out secrets). However, since we don't have a use-case to actually read the secrets in the first place, we aren't currently hydrating them. This simply doesn't work, since the SecretsRepositoryWriter expects the secrets to be hydrated.
As a result, a workspace that has a webhook config set can't be updated.
How
Only use the secrets persistence layer if we created new secrets or ever hydrated existing ones.