Exclude connectors with unsupported protocol version from seed updates #19328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosusnp
requested review from
colesnodgrass,
jdpgrailsdev,
benmoriceau and
alovew
benmoriceau
approved these changes
Nov 15, 2022
| @@ -73,13 +73,13 @@ public Optional<AirbyteProtocolVersionRange> validate(final boolean supportAutoU | |||
| return Optional.of(targetRange); | |||
| } | |||
|
|
|||
| if (currentRange.equals(targetRange)) { | |||
| if (currentRange.isEmpty() || currentRange.get().equals(targetRange)) { | |||
There was a problem hiding this comment.
nit; if (currentRangs.orElse(targetRange).equals(targetRange))
alovew
approved these changes
Nov 15, 2022
gosusnp
deleted the
gosusnp/prevent-upgrading-out-of-range-connectors
branch
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
#19328) * Filter out connectors with unsupported protocol in ApplyDefinitionsHelper * Format * Remove code dupl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When apply connector updates from seeds, we should check that the connectors have supported protocol versions.
Relates to #15463
How
Add a filter on protocol version in
ApplyDefinitionsHelper.NOTE: there is currently some duplication, this is partly due to concurrent PRs. I will have a follow up PR to merge the duplicated parts and remove the deprecated constructors once we bumped cloud.
Recommended reading order
ApplyDefinitionsHelper.javacontains the main logicDefaultJobPersistence.javacontains a helper to retrieve the current protocol version support range