-
Notifications
You must be signed in to change notification settings - Fork 4.6k
CDK: don't filter failed interpolated vars for request_options_provider.request_body_json
#19297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grubberr
merged 11 commits into
master
from
grubberr/cdk-json-interpolated_request_input_provider
Nov 11, 2022
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1a5ec13
skip filtering for get_request_body_json
grubberr 34f3060
test_interpolated_request_json fixed
grubberr 95dd447
bump 0.8.1
grubberr 6451ef4
re-implement with filter_items
grubberr 851e492
Merge branch 'master' into grubberr/cdk-json-interpolated_request_inp…
grubberr 4462b23
tests improved
grubberr 172d43b
CHANGELOG.md updated
grubberr f5da72c
Merge branch 'master' into grubberr/cdk-json-interpolated_request_inp…
grubberr decd1f8
re-implement
grubberr 98f4e51
Merge branch 'master' into grubberr/cdk-json-interpolated_request_inp…
grubberr 796275a
code lint
grubberr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would we want to return
None
in the request body?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory I can imagine something like this:
But to be honest we did not encounter in this for now. For now we need only this:
I have re-implemented doing less radical changes
What do you think now?