Skip to content

Metric fixes on multi cloud #19268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2022
Merged

Metric fixes on multi cloud #19268

merged 2 commits into from
Nov 10, 2022

Conversation

xiaohansong
Copy link
Contributor

What

  • OldestPending Jobs need to return string rather than enum;
  • SaveAttemptInfoToWorkflow needs to happen only on replication stage, otherwise it will be overwritten by empty queue names.

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Nov 10, 2022
davinchia
davinchia approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix!

Did our test not catch this because it was mocked out?

@xiaohansong
Copy link
Contributor Author

Yes exactly.

@xiaohansong xiaohansong merged commit bde7fe9 into master Nov 10, 2022
@xiaohansong xiaohansong deleted the xiaohan/backfill branch November 10, 2022 17:05
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
@xiaohansong @akashkulk
Metric fixes on multi cloud (#19268)
b5cfd7e 
* fix numpending secs

* fix worker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaohansong @davinchia