Fix OAuth login buttons #19135
Merged
Fix OAuth login buttons #19135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
type/bug
timroes
commented
Nov 8, 2022
| @@ -63,7 +63,7 @@ export const ConnectorFormContextProvider: React.FC<React.PropsWithChildren<Conn | |||
|
|
|||
| const ctx = useMemo<ConnectorFormContext>(() => { | |||
| const unfinishedFlows = widgetsInfo["_common.unfinishedFlows"] ?? {}; | |||
| return { | |||
| const context: ConnectorFormContext = { | |||
There was a problem hiding this comment.
ℹ️ Assigning this object to a variable that's explicitally types, will cause TypeScript to now properly check if the object has keys that it shouldn't have.
dizel852
approved these changes
Nov 8, 2022
|
Can't approve, but tested locally and am seeing the OAuth button on all OAuth connectors. I do see a bug where the auth method is persisting if i navigate away and often no default auth method is being applied if it is in a oneOf. |
edmundito
approved these changes
Nov 8, 2022
lmossman
approved these changes
Nov 8, 2022
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Fix OAuth login buttons * Remove unnecessary "as unknown" * Prevent empty number fields from breaking * Fix issue with default values * Fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes several issues with the OAuth connectors atm:
connectorFormContextdoes no longer containselectedServiceandselectedConnector, but the consuming places were not adjusted to that yet. This fixes the consuming places and the types.getValuessince the refactor to theuseAuthenticationhook, which would cause connectors (like Bing Ads), which had apredicateKeyreferencing a field that only had aconstvalue to no longer show. Since thegetValuesmethod is the one that put thatconstvalue as a default value into the Formik values.defaultvalue for one of the OAuth flow fields of empty string, which caused our check forundefinedthough to now think the OAuth flow already ran. This was now changed to a truthy change, so empty string default values in OAuth flow fields no longer mark the button as "Reauthenticate" from the beginning.