Skip to content

🪟🧪 [Experiment] Move OAuth to top of signup page #18899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2022
Merged

🪟🧪 [Experiment] Move OAuth to top of signup page #18899

merged 3 commits into from
Nov 7, 2022

Conversation

letiescanciano
Copy link
Contributor

@letiescanciano letiescanciano commented Nov 3, 2022 •
edited
Loading

Hypothesis: We know that 50% of our signups use Google OAuth. We can test if bringing it higher on the page increases the signup conversion rate even more.

Goal: 2% increase of conversion rate in Signup Page.

Experiment

Demo: https://www.loom.com/share/b10dfc5249e244498df85338b27b76d9

What

Changing the position of the OAuth block on Signup depending on FF value

Before
Screen Shot 2022-11-03 at 11 02 08 AM

After
Screen Shot 2022-11-03 at 11 01 07 AM

@letiescanciano letiescanciano requested a review from a team as a code owner November 3, 2022 10:02
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 3, 2022
letiescanciano
letiescanciano commented Nov 3, 2022
View reviewed changes
airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.tsx
@@ -100,9 +100,6 @@ export const OAuthLogin: React.FC<OAuthLoginProps> = ({ isSignUpPage }) => {

return (
<div>
<div className={styles.separator}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted as <Separator />

letiescanciano
letiescanciano commented Nov 3, 2022
View reviewed changes
airbyte-webapp/src/packages/cloud/views/auth/SignupPage/SignupPage.module.scss
@@ -1,6 +1,12 @@
@use "../../../../../scss/colors";
@use "../../../../../scss/variables";

.container {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding styles for Signup Page Container, as it should be responsible of positioning elements on it.

@timroes
Copy link
Contributor

timroes commented Nov 7, 2022

Question (and maybe that's worth putting into the PR description for further experiments in general): What are we trying to test here, i.e. what is the goal of the experiment to figure out? Higher sign-up rates? More percentage of OAuth sign-ups? I'm mostly trying to understand, why we run it as an exeperiment in the first place, instead of simply changing the order without a flag.

@timroes
Copy link
Contributor

timroes commented Nov 7, 2022

The separator is lost on the login page with this change:

screenshot-20221107-121108

@letiescanciano
Copy link
Contributor Author

Question (and maybe that's worth putting into the PR description for further experiments in general): What are we trying to test here, i.e. what is the goal of the experiment to figure out? Higher sign-up rates? More percentage of OAuth sign-ups? I'm mostly trying to understand, why we run it as an exeperiment in the first place, instead of simply changing the order without a flag.

Updated! Agreed that including the goal + hypothesis of the experiment will be helpful.
In this case, I feel like having the FF + Experiment is not a lot of work (and easy to remove in the future) and will allow us to easily change the config from LD and see the difference between the variant and the baseline. (Also easy experiment to keep evaluating LD Experimentation feature)

@letiescanciano
Copy link
Contributor Author

The separator is lost on the login page with this change:

screenshot-20221107-121108

Updated!
Screen Shot 2022-11-07 at 1 25 33 PM

@letiescanciano
Merge branch 'master' into leti/move-oauth-to-the-top
6c7a97f 
* master: (73 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
timroes
timroes approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have tested locally that the sign-up page and login page are working as expected, with both positions.

@letiescanciano letiescanciano merged commit 83a943c into master Nov 7, 2022
@letiescanciano letiescanciano deleted the leti/move-oauth-to-the-top branch November 7, 2022 13:02
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-add-source-in-signup
4127ba1 
* master:
  🪟 🎨 Adapt Osano banner to new UI (#19029)
  🪟 🔧 Add a start:cloud command to the webapp (#19026)
  🪟🧪 [Experiment] Move OAuth to top of signup page (#18899)
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/growth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letiescanciano @timroes