Job Persistence Refactor in preparation for progress bar. #18891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd an attempt number.
davinchia
commented
Nov 3, 2022
| @@ -29,14 +29,14 @@ | |||
| import java.util.stream.Stream; | |||
|
|
|||
| /** | |||
| * TODO Introduce a locking mechanism so that no DB operation is allowed when automatic migration is | |||
There was a problem hiding this comment.
This comment is out of date. I replaced it with something more useful.
davinchia
commented
Nov 3, 2022
| @@ -382,6 +365,24 @@ public void writeOutput(final long jobId, final int attemptNumber, final JobOutp | |||
|
|
|||
| } | |||
|
|
|||
| private static void writeSyncStats(final OffsetDateTime now, final SyncStats syncStats, final Long attemptId, final DSLContext ctx) { | |||
There was a problem hiding this comment.
I pulled this out as I will reuse this in follow up PRs as I implement the progress bar logic.
davinchia
commented
Nov 3, 2022
| @@ -285,13 +285,7 @@ void testWriteOutput() throws IOException, SQLException { | |||
| assertEquals(Optional.of(jobOutput), updated.getAttempts().get(0).getOutput()); | |||
| assertNotEquals(created.getAttempts().get(0).getUpdatedAtInSecond(), updated.getAttempts().get(0).getUpdatedAtInSecond()); | |||
|
|
|||
| final Optional<Record> record = | |||
There was a problem hiding this comment.
Replacing jobId and attemptNumber also simplifies how the methods are used.
The alternative is exposing a helper method to calculate the attemptId - this feels unnecessary.
|
@davinchia Looks like the build failed due to a formatting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some refactoring in preparation for the progress bar persistence changes.
The main change here was to simplify some of the
JobPersistencemethods by moving the logic to calculateattemptIdinto theJobPersistenceimplementation. This logic currently sits outside the class and is duplicated in multiple places. We could expose a helper method to calculate this logic, however that felt unnecessary at this point.The alternative is further duplicating this logic as the progress bar logic is implemented, so I want to get that out of the way.
The other reason it's cleaner to use
jobIdandattemptNumberis these concepts/terms are more familiar throughout the rest of the codebase and it feels more intuitive to continue speaking this language (in my opinion).Some random bits I wanted to clean up on the way as well. I will leave comments in the files as appropriate.
How
getSyncStats(Long attemptId)->getSyncStats(long jobId, int attemptNumber)getNormalizationSummary(Long attemptId)->getNormalizationSummary(long jobId, int attemptNumber)I also pulled out method that I will need to use in follow up PRs.
Recommended reading order
JobPersistence.javafor the main changes.🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.