-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Show version and changelog status for affected connectors #18845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c1b0db0
Add placeholder change
tuliren a9194a6
List connectors and versions in a table
tuliren 799eaa4
Add changelog status
tuliren 231e786
Add changelog annotation
tuliren 5fd165d
Add publish version status
tuliren 5378077
Add version bump for demo
tuliren d17c6c9
Update status
tuliren bc039d7
Add strict-encrypt verion check
tuliren b7043a4
Add overall status summary
tuliren 1bd7984
Fix version status format
tuliren d942050
Fix format
tuliren dc2f13f
Update styling
tuliren e562d88
Add notes
tuliren 701f776
Add a special case for mongodb
tuliren 0fdb9db
Update details open / close logic
tuliren 41d7586
Add link to dockerfile
tuliren 0d93d3d
Revert demo changes
tuliren 0431a0d
Remove version link
tuliren 7117c24
Merge branch 'master' of github.com:airbytehq/airbyte into liren/fanc…
tuliren f0008e4
Delete report when it is deprecated
tuliren 6f30e9a
Revert "Delete report when it is deprecated"
tuliren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 36 additions & 7 deletions
43
.github/comment_templates/connector_dependency_template.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,54 @@ | ||
<!--- this comment is for `report-connectors-dependency.yml` identification, do not remove --> | ||
|
||
NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests: | ||
NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed: | ||
- Run integration tests | ||
- Bump connector version | ||
- Add changelog | ||
- Publish the new version | ||
|
||
<details> | ||
<details {source_open}> | ||
<summary> | ||
Sources ({num_sources}) | ||
|
||
### {source_status_summary} Sources ({num_sources}) | ||
|
||
</summary> | ||
|
||
{sources} | ||
| Connector | Version | Changelog | Publish | | ||
| --- | :---: | :---: | :---: | | ||
{source_rows} | ||
|
||
</details> | ||
|
||
<details> | ||
<details {destination_open}> | ||
<summary> | ||
Destinations ({num_destinations}) | ||
|
||
### {destination_status_summary} Destinations ({num_destinations}) | ||
|
||
</summary> | ||
|
||
{destinations} | ||
| Connector | Version | Changelog | Publish | | ||
| --- | :---: | :---: | :---: | | ||
{destination_rows} | ||
|
||
</details> | ||
|
||
{others} | ||
|
||
<details> | ||
|
||
<summary> | ||
|
||
### Notes | ||
|
||
</summary> | ||
|
||
| Category | Status | Actionable Item | | ||
| --- | :---: | --- | | ||
| Version | ❌<br/>mismatch | The version of the connector is different from its normal variant. Please bump the version of the connector. | | ||
| | ⚠<br/>doc not found | The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug. | | ||
| Changelog | ⚠<br/>doc not found | The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug. | | ||
| | ❌<br/>changelog missing | There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | | ||
| Publish | ⚠<br/>not in seed | The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. | | ||
| | ❌<br/>diff seed version | The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version. | | ||
|
||
</details> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.