🎉 New source: Gong [low-code cdk] #18819

elliottrabac · 2022-11-01T22:01:53Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

Connector contest: Source: Gong connector-contest#23

How

Describe the solution

Implementing the Gong connector with relevant streams using the low Code CDK.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…irbyte into elliot/new-gong-connector

marcosmarxm

Hello @elliottrabac, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm · 2022-11-04T08:55:55Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm

Thanks @elliottrabac I'll publish later this week this amazing connector!

marcosmarxm · 2022-11-10T13:19:11Z

I tested the connector locally, but because the credentials use production data I won't create the secrets in GSM.

marcosmarxm · 2022-11-10T13:19:20Z

/publish connector=connectors/source-gong run-tests=false

🕑 Publishing the following connectors:
connectors/source-gong
https://github.com/airbytehq/airbyte/actions/runs/3437138799

Connector	Did it publish?	Were definitions generated?
connectors/source-gong	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks @elliottrabac

* create boilerplate * configure streams * add docs * edit schemas * add gong to source def * add gong to source def * auto-bump connector version Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: Marcos Marx <[email protected]>

elliottrabac added 2 commits November 1, 2022 19:49

create boilerplate

e5006ad

configure streams

398d5f9

github-actions bot added the area/connectors Connector related issues label Nov 1, 2022

octavia-squidington-iv added community connectors/source/gong labels Nov 1, 2022

elliottrabac and others added 4 commits November 2, 2022 05:43

add docs

34c92f9

Merge branch 'master' into elliot/new-gong-connector

b122125

edit schemas

24639c2

Merge branch 'elliot/new-gong-connector' of github.com:elliottrabac/a…

c69a609

…irbyte into elliot/new-gong-connector

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 2, 2022

elliottrabac marked this pull request as ready for review November 2, 2022 04:53

octavia-squidington-iv added the bounty label Nov 2, 2022

marcosmarxm added the hacktober label Nov 2, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

Merge branch 'master' into elliot/new-gong-connector

f631bde

elliottrabac requested a review from marcosmarxm November 8, 2022 10:09

elliottrabac and others added 3 commits November 8, 2022 14:35

Merge branch 'master' into elliot/new-gong-connector

8fc31c0

add gong to source def

ff104b0

add gong to source def

67dd357

marcosmarxm approved these changes Nov 9, 2022

View reviewed changes

octavia-squidington-iii and others added 2 commits November 10, 2022 13:31

auto-bump connector version

e1d0197

Merge branch 'master' into elliot/new-gong-connector

e95251a

marcosmarxm approved these changes Nov 10, 2022

View reviewed changes

marcosmarxm merged commit c755439 into airbytehq:master Nov 10, 2022

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New source: Gong~~ 🎉 New source: Gong [low-code cdk] Nov 18, 2022

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🎉 New source: Gong [low-code cdk] #18819

🎉 New source: Gong [low-code cdk] #18819

Uh oh!

elliottrabac commented Nov 1, 2022 •

edited

Loading

Uh oh!

marcosmarxm left a comment

Uh oh!

marcosmarxm commented Nov 4, 2022

Uh oh!

marcosmarxm left a comment

Uh oh!

marcosmarxm commented Nov 10, 2022

Uh oh!

marcosmarxm commented Nov 10, 2022 •

edited by github-actions bot

Loading

Uh oh!

marcosmarxm left a comment

Uh oh!

Uh oh!

🎉 New source: Gong [low-code cdk] #18819

🎉 New source: Gong [low-code cdk] #18819

Uh oh!

Conversation

elliottrabac commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

Uh oh!

marcosmarxm left a comment

Choose a reason for hiding this comment

Uh oh!

marcosmarxm commented Nov 4, 2022

Uh oh!

marcosmarxm left a comment

Choose a reason for hiding this comment

Uh oh!

marcosmarxm commented Nov 10, 2022

Uh oh!

marcosmarxm commented Nov 10, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcosmarxm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elliottrabac commented Nov 1, 2022 •

edited

Loading

marcosmarxm commented Nov 10, 2022 •

edited by github-actions bot

Loading