🎉 New Source: GNews [low-code CDK] #18808

Xabilahu · 2022-11-01T20:06:48Z

What

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Xabilahu · 2022-11-01T20:12:33Z

secrets/config.json being used for integ tests is:

{
  "api_key": "API-KEY",
  "query": "Apple OR Microsoft",
  "top_headlines_topic": "technology"
}

marcosmarxm

Hello @Xabilahu, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

Xabilahu · 2022-11-02T10:27:28Z

Hi @marcosmarxm, thanks for the update! Below the status of the checklist:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

marcosmarxm

Requesting about incremental syncs.

marcosmarxm · 2022-11-02T23:25:06Z

airbyte-integrations/connectors/source-gnews/source_gnews/gnews.yaml

+    from: "{{ config['from'] }}"
+    to: "{{ config['to'] }}"


@Xabilahu similar case as New York, what about implementing incremental syncs to this API?

Xabilahu · 2022-11-03T22:00:56Z

I implemented support for incremental syncs and error handling. I need some help figuring out some problem for the error handlers. I already sent a message in the hacktoberfest-2022 slack channel. Pasting the message here for reference:

Hi guys! I'm trying to add some backoff strategies to a low-code CDK based connector, and I found that in the docs backoff strategies are mentioned like ConstantBackoff, whereas the CDK implementation says ConstantBackoffStrategy. This happens for every backoff strategy.

Moreover, I get the following error with this definition:

    error_handler:
      type: "CompositeErrorHandler"
      error_handlers:
        - response_filters:
          - http_codes: [ 429 ]
            action: RETRY
          backoff_strategies:
            - type: "ConstantBackoffStrategy"
              backoff_time_in_seconds: 1.0
        - response_filters:
          - http_codes: [ 403 ]
            action: RETRY
          backoff_strategies:
            - class_name: "source_gnews.WaitUntilMidnightBackoffStrategy"

It seems that there is no support for $options:

Exception: failed to create object of type <class 'airbyte_cdk.sources.declarative.requesters.error_handlers.backoff_strategies.constant_backoff_strategy.ConstantBackoffStrategy'> because __init__() got an unexpected keyword argument 'options'

Am I missing something?

Xabilahu · 2022-11-04T08:35:02Z

As per @girarda, this issue should be fixed by #18053

marcosmarxm · 2022-11-04T08:55:24Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm · 2022-11-08T12:47:19Z

@Xabilahu I'm having problem running tests with ./gradlew airbyte-integrations:connectors:source-gnews:integrationTest can you check if you can run locally?

Xabilahu · 2022-11-08T19:10:26Z

@marcosmarxm Tests are passing now ;)

marcosmarxm · 2022-11-09T13:32:00Z

/test connector=connectors/source-gnews

🕑 connectors/source-gnews https://github.com/airbytehq/airbyte/actions/runs/3428580314
✅ connectors/source-gnews https://github.com/airbytehq/airbyte/actions/runs/3428580314
Python tests coverage:

Name                                                   Stmts   Miss  Cover
--------------------------------------------------------------------------
source_gnews/wait_until_midnight_backoff_strategy.py      16      0   100%
source_gnews/__init__.py                                   3      0   100%
source_gnews/source.py                                     4      1    75%
--------------------------------------------------------------------------
TOTAL                                                     23      1    96%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              345    110    68%   53, 64-72, 77-84, 88-89, 93-94, 178, 216-233, 242-250, 254-259, 265, 298-303, 341-348, 391-393, 396, 461-469, 481-484, 489, 545-546, 552, 555, 591-601, 614-639
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1512    375    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:65: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:243: The previous connector image could not be retrieved.
======================== 27 passed, 2 skipped in 51.57s ========================

marcosmarxm · 2022-11-09T13:45:18Z

/publish connector=connectors/source-gnews

🕑 Publishing the following connectors:
connectors/source-gnews
https://github.com/airbytehq/airbyte/actions/runs/3428672357

Connector	Did it publish?	Were definitions generated?
connectors/source-gnews	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks @Xabilahu

* Initial GNews source connector implementation * Update changelog with PR id * Add support for incremental syncs and error handling * Make tests pass * run format * auto-bump connector version Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: Marcos Marx <[email protected]>

Xabilahu added 2 commits November 1, 2022 21:01

Initial GNews source connector implementation

76d8b2a

Merge branch 'airbytehq:master' into gnews

7f21f2e

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 1, 2022

octavia-squidington-iv added bounty community connectors/source/gnews labels Nov 1, 2022

Xabilahu mentioned this pull request Nov 1, 2022

New Source: GNews airbytehq/connector-contest#253

Closed

Update changelog with PR id

9c647a4

Xabilahu changed the title ~~🎉 New Source: Gnews [low-code CDK]~~ 🎉 New Source: GNews [low-code CDK] Nov 1, 2022

marcosmarxm added the hacktober label Nov 1, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

Xabilahu requested a review from marcosmarxm November 2, 2022 10:27

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

Add support for incremental syncs and error handling

de507a0

Xabilahu added 2 commits November 8, 2022 19:23

Merge branch 'airbytehq:master' into gnews

2b68fc1

Make tests pass

f06803e

Xabilahu requested a review from marcosmarxm November 8, 2022 19:10

run format

46eabb7

octavia-squidington-iii and others added 2 commits November 9, 2022 14:04

auto-bump connector version

ad2ee82

Merge branch 'master' into gnews

035eb0b

marcosmarxm approved these changes Nov 9, 2022

View reviewed changes

marcosmarxm merged commit 88d743b into airbytehq:master Nov 9, 2022

Xabilahu deleted the gnews branch November 10, 2022 10:13

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🎉 New Source: GNews [low-code CDK] #18808

🎉 New Source: GNews [low-code CDK] #18808

Uh oh!

Xabilahu commented Nov 1, 2022

Uh oh!

Xabilahu commented Nov 1, 2022

Uh oh!

marcosmarxm left a comment

Uh oh!

Xabilahu commented Nov 2, 2022

Uh oh!

marcosmarxm left a comment

Uh oh!

marcosmarxm Nov 2, 2022

Uh oh!

Xabilahu commented Nov 3, 2022

Uh oh!

Xabilahu commented Nov 4, 2022

Uh oh!

marcosmarxm commented Nov 4, 2022

Uh oh!

marcosmarxm commented Nov 8, 2022 •

edited

Loading

Uh oh!

Xabilahu commented Nov 8, 2022

Uh oh!

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

Uh oh!

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

Uh oh!

marcosmarxm left a comment

Uh oh!

Uh oh!

🎉 New Source: GNews [low-code CDK] #18808

🎉 New Source: GNews [low-code CDK] #18808

Uh oh!

Conversation

Xabilahu commented Nov 1, 2022

What

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

Uh oh!

Xabilahu commented Nov 1, 2022

Uh oh!

marcosmarxm left a comment

Choose a reason for hiding this comment

Uh oh!

Xabilahu commented Nov 2, 2022

Uh oh!

marcosmarxm left a comment

Choose a reason for hiding this comment

Uh oh!

marcosmarxm Nov 2, 2022

Choose a reason for hiding this comment

Uh oh!

Xabilahu commented Nov 3, 2022

Uh oh!

Xabilahu commented Nov 4, 2022

Uh oh!

marcosmarxm commented Nov 4, 2022

Uh oh!

marcosmarxm commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xabilahu commented Nov 8, 2022

Uh oh!

marcosmarxm commented Nov 9, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

marcosmarxm commented Nov 9, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcosmarxm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcosmarxm commented Nov 8, 2022 •

edited

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 9, 2022 •

edited by github-actions bot

Loading