Skip to content

New Source: Gridly #18342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 3, 2022
Merged

New Source: Gridly #18342

merged 10 commits into from
Nov 3, 2022

Conversation

hntan
Copy link
Contributor

@hntan hntan commented Oct 23, 2022

What

Add source Gridly. Gridly is a spreadsheet-based content management. It helps to manage your games or applications content in one place.

How

Using Gridly API. This connector contains record streams: Record which is the main data on Gridly. The connector requires two parameters: api_key and grid_id (or branch_id).

Recommended reading order

  1. spec.yaml
  2. source.py
  3. helpers.py

🚨 User Impact 🚨

There is no change to the existing code

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector: Gridly

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Screen Shot 2022-10-25 at 2 34 20 PM Screen Shot 2022-10-25 at 2 34 29 PM
Acceptance

Put your acceptance tests output here.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 23, 2022
@hntan hntan changed the title Add source-gridly New Source: Gridly Oct 23, 2022
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, almost done!

@marcosmarxm
Copy link
Member

@hntan can you share the output of ./gradlew airbyte-integrations:connectors:source-gridly:integrationTest?

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 27, 2022
@hntan
Copy link
Contributor Author

hntan commented Oct 27, 2022

@hntan can you share the output of ./gradlew airbyte-integrations:connectors:source-gridly:integrationTest?

Hi @marcosmarxm, below is the result of integrationTest

Screen Shot 2022-10-27 at 12 12 56 PM

Screen Shot 2022-10-27 at 12 13 24 PM

Screen Shot 2022-10-27 at 12 13 35 PM

@hntan hntan requested a review from marcosmarxm October 28, 2022 11:31
@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 3, 2022

/test connector=connectors/source-gridly

🕑 connectors/source-gridly https://github.com/airbytehq/airbyte/actions/runs/3386310563
✅ connectors/source-gridly https://github.com/airbytehq/airbyte/actions/runs/3386310563
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gridly/__init__.py       2      0   100%
source_gridly/helpers.py       96     26    73%
source_gridly/source.py        84     34    60%
-----------------------------------------------
TOTAL                         182     60    67%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
================= 24 passed, 3 skipped, 27 warnings in 21.90s ==================

@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 3, 2022

/publish connector=connectors/source-gridly

🕑 Publishing the following connectors:
connectors/source-gridly
https://github.com/airbytehq/airbyte/actions/runs/3386442108


Connector Did it publish? Were definitions generated?
connectors/source-gridly

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hntan

@marcosmarxm marcosmarxm merged commit f156be9 into airbytehq:master Nov 3, 2022
letiescanciano added a commit that referenced this pull request Nov 3, 2022
* master: (38 commits)
  New Source: Gridly (#18342)
  🎉 New Source: Alpha Vantage (#18320)
  ci_integration_test.sh: cut GITHUB_STEP_SUMMARY (#18895)
  🎉 New Source: Datadog [python cdk] (#18150)
  Hide Reject all button in consent dialog (#18596)
  feat: add doc url to track event (#18690)
  fix: install java in oss catalog deploy action (#18887)
  [CI] Speed up check_images_exist (#18873)
  Extract open API (#18879)
  Remove unused interfaces (#18880)
  add action for deploying oss connector catalog to GCS (#18633)
  feat: generate full connector catalog json (#18562)
  Add unsupported_protocol_version column to Connection (#18876)
  Extract OAuth API (#18818)
  update images to have non-transparent background (#18874)
  DiscoverSchema endpoints calculates diff and breaking change (#18571)
  Validate protocol version on connector update (#18639)
  Bmoric/extract notification api (#18812)
  Show version and changelog status for affected connectors (#18845)
  Bmoric/extract logs api (#18621)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/gridly hacktober internal python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants