Skip to content

🐛 Source Bing Ads - Fix Campaigns stream misses Audience and Shopping #17873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 14, 2022
Merged

🐛 Source Bing Ads - Fix Campaigns stream misses Audience and Shopping #17873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0a2048
fix(source-bing-ads): explicitly add all campaigns type in request pa…
rach-r Oct 12, 2022
2e1be57
test(source-bing-ads): update unit tests to check all campaign types …
rach-r Oct 12, 2022
a19ed4a
chore(source-bing-ads): bump version to 0.1.16
rach-r Oct 12, 2022
53c74b0
docs(souce-bing-ads): update changelog
rach-r Oct 12, 2022
46c71c4
Merge branch 'master' into fix-missing-campaigns-bing-ads
alafanechere Oct 12, 2022
7d62993
refactor(source-bing-ads): additional_fields and campaign_types as li…
rach-r Oct 12, 2022
e498138
Merge branch 'master' into fix-missing-campaigns-bing-ads
alafanechere Oct 13, 2022
b50487a
auto-bump connector version [ci skip]
octavia-squidington-iii Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
- name: Bing Ads
sourceDefinitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerRepository: airbyte/source-bing-ads
dockerImageTag: 0.1.15
dockerImageTag: 0.1.16
documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
icon: bingads.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,7 +1460,7 @@
- "overwrite"
- "append"
- "append_dedup"
- dockerImage: "airbyte/source-bing-ads:0.1.15"
- dockerImage: "airbyte/source-bing-ads:0.1.16"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/bing-ads"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.15
LABEL io.airbyte.version=0.1.16
LABEL io.airbyte.name=airbyte/source-bing-ads
21 changes: 15 additions & 6 deletions airbyte-integrations/connectors/source-bing-ads/source_bing_ads/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,19 @@ class Campaigns(BingAdsStream):
data_field: str = "Campaign"
service_name: str = "CampaignManagement"
operation_name: str = "GetCampaignsByAccountId"
additional_fields: str = (
"AdScheduleUseSearcherTimeZone BidStrategyId CpvCpmBiddingScheme DynamicDescriptionSetting"
" DynamicFeedSetting MaxConversionValueBiddingScheme MultimediaAdsBidAdjustment"
" TargetImpressionShareBiddingScheme TargetSetting VerifiedTrackingSetting"
)
additional_fields: Iterable[str] = [
"AdScheduleUseSearcherTimeZone",
"BidStrategyId",
"CpvCpmBiddingScheme",
"DynamicDescriptionSetting",
"DynamicFeedSetting",
"MaxConversionValueBiddingScheme",
"MultimediaAdsBidAdjustment",
"TargetImpressionShareBiddingScheme",
"TargetSetting",
"VerifiedTrackingSetting",
]
campaign_types: Iterable[str] = ["Audience", "DynamicSearchAds", "Search", "Shopping"]

def request_params(
self,
Expand All @@ -215,7 +223,8 @@ def request_params(
) -> MutableMapping[str, Any]:
return {
"AccountId": stream_slice["account_id"],
"ReturnAdditionalFields": self.additional_fields,
"CampaignType": " ".join(self.campaign_types),
"ReturnAdditionalFields": " ".join(self.additional_fields),
}

def stream_slices(
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-bing-ads/unit_tests/test_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def test_campaigns_request_params(mocked_client, config):
request_params = campaigns.request_params(stream_slice={"account_id": "account_id"})
assert request_params == {
"AccountId": "account_id",
"CampaignType": "Audience DynamicSearchAds Search Shopping",
"ReturnAdditionalFields": "AdScheduleUseSearcherTimeZone BidStrategyId CpvCpmBiddingScheme DynamicDescriptionSetting DynamicFeedSetting MaxConversionValueBiddingScheme MultimediaAdsBidAdjustment TargetImpressionShareBiddingScheme TargetSetting VerifiedTrackingSetting",
}

Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/bing-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ The Bing Ads API limits the number of requests for all Microsoft Advertising cli

## Changelog
| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------- |
| :------ |:-----------|:---------------------------------------------------------------------------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------|
| 0.1.16 | 2022-10-12 | [17873](https://github.com/airbytehq/airbyte/pull/17873) | Fix: added missing campaign types in (Audience, Shopping and DynamicSearchAds) in campaigns stream |
| 0.1.15 | 2022-10-03 | [17505](https://github.com/airbytehq/airbyte/pull/17505) | Fix: limit cache size for ServiceClient instances |
| 0.1.14 | 2022-09-29 | [17403](https://github.com/airbytehq/airbyte/pull/17403) | Fix: limit cache size for ReportingServiceManager instances |
| 0.1.13 | 2022-09-29 | [17386](https://github.com/airbytehq/airbyte/pull/17386) | Migrate to per-stream states. |
Expand Down