Skip to content

🪟 🔧 Publish webapp storybook to chromatic in CI #16169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 8, 2022
Merged

🪟 🔧 Publish webapp storybook to chromatic in CI #16169

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
da48ddd
Add Publish to storybook step in webapp gradle workflow
edmundito Aug 30, 2022
15cfca8
Set fetch-dept to 0 for airbyte webapp build
edmundito Aug 30, 2022
3515326
Fix typo in chromatic config
edmundito Aug 30, 2022
595d158
Fix typo when you've been writing too much css
edmundito Aug 30, 2022
9acdee4
Fix storybook build path in gradle workflow
edmundito Aug 30, 2022
13dd2fc
Use full path in chromatic action
edmundito Aug 30, 2022
28e683c
Try another path configuration for chromatic workflow action
edmundito Aug 30, 2022
44cf727
Use label ot token in storybook deploy
edmundito Aug 31, 2022
60bb585
Back to github_token
edmundito Aug 31, 2022
963263b
Move Storybook deploy to separate job
edmundito Aug 31, 2022
2cae879
Fix run command in publish storybook workflow
edmundito Sep 1, 2022
c5378fb
Rollback publish storybook as separate step from build-frontend, add …
edmundito Sep 1, 2022
b81f622
Let the chromatic step build the storybook
edmundito Sep 1, 2022
f66ec91
Restore storybookBuildDir on publish to chromatic step
edmundito Sep 2, 2022
3d61e2a
Add exitOnceUploaded to chromatic action
edmundito Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,15 @@ jobs:
github-token: ${{ needs.find_valid_pat.outputs.pat }}
frontend-build:
name: "Frontend: Build"
needs: start-frontend-runner
needs:
- start-frontend-runner
- find_valid_pat
runs-on: ${{ needs.start-frontend-runner.outputs.label }}
steps:
- name: Checkout Airbyte
uses: actions/checkout@v2
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why add this?

Copy link
Contributor Author

@edmundito edmundito Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for Chromatic to be able to track the history:

Chromatic supports the latest versions of the actions/checkout (i.e., versions 2 and 3). Both of them come with a caveat. They will only retrieve a single commit without any additional history. Chromatic needs the full Git history to keep track of changes in your repository.

https://www.chromatic.com/docs/github-actions#support-for-codeactionscheckoutv2code-and-above

fetch-depth: 0

- name: Cache Build Artifacts
uses: ./.github/actions/cache-build-artifacts
Expand Down Expand Up @@ -333,6 +337,17 @@ jobs:

- name: Build :airbyte-webapp
run: SUB_BUILD=PLATFORM ./gradlew --no-daemon :airbyte-webapp:build --scan

- name: Publish Storybook to Chromatic
uses: chromaui/action@v1
with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
token: ${{ needs.find_valid_pat.outputs.pat }}
workingDir: ./airbyte-webapp/
storybookBuildDir: build/storybook/
exitOnceUploaded: true


frontend-test:
name: "Frontend: Run End-to-End Tests"
needs:
Expand Down