Skip to content

🐞 Postgres source: remove config logging #16138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2022
Merged

🐞 Postgres source: remove config logging #16138

merged 4 commits into from
Aug 30, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Aug 30, 2022 •
edited
Loading

Summary

  • Remove unnecessary logging of the db config.

@tuliren tuliren requested a review from a team as a code owner August 30, 2022 18:04
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 30, 2022
ryankfu
ryankfu approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for owning this change

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-postgres-strict-encrypt

1 similar comment
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-postgres-strict-encrypt

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-postgres-strict-encrypt

@tuliren
Copy link
Contributor Author

tuliren commented Aug 30, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres-strict-encrypt run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/2958709116


Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@tuliren
Copy link
Contributor Author

tuliren commented Aug 30, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/2958708371


Connector Did it publish? Were definitions generated?
connectors/source-postgres ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@tuliren tuliren merged commit 0910dd1 into master Aug 30, 2022
@tuliren tuliren deleted the liren/remove-db-config-log branch August 30, 2022 19:26
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 2, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@tuliren @octavia-squidington-iii @robbinhan
🐞 Postgres source: remove config logging (airbytehq#16138)
3d68eb6 
* Remove config logging

* Update pr id

* Fix changelog date

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subodh1810 subodh1810 subodh1810 approved these changes

@ryankfu ryankfu ryankfu approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres connectors/source/postgres-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuliren @subodh1810 @ryankfu @octavia-squidington-iii