fix: Update oss charts. Add acceptance tests for helm #16131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
37 tasks
|
@xpuska513 what else is remaining in this PR? Does it need another review? Want to be aware of leaving this hanging for too long. |
|
I think we can merge it in, since it's too big anyways. If there's something left it's probably minor thing and won't break the charts itself |
davinchia
approved these changes
Sep 9, 2022
This was referenced Sep 12, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * add step to install unzip * fix incorrect command spelling(helm) * update slack notification sending for Airbyte CI workflow * Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * do a small testing for sake of science * Update test chart.yaml with note block * Revert changes for AC tests * fix: Include airbytehq#16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs Co-authored-by: Davin Chia <[email protected]>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * add step to install unzip * fix incorrect command spelling(helm) * update slack notification sending for Airbyte CI workflow * Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * do a small testing for sake of science * Update test chart.yaml with note block * Revert changes for AC tests * fix: Include airbytehq#16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs Co-authored-by: Davin Chia <[email protected]>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.