Source file-secure: bump to 0.2.15 #15416

girarda · 2022-08-08T18:46:38Z

What

The file connector was upgraded to 0.2.15, but not the secure version of the connector.
This upgrades the secure connector to 0.2.15

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

girarda · 2022-08-08T18:49:03Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/2820212936

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

girarda · 2022-08-08T19:19:25Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/2820391533

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

girarda · 2022-08-08T19:38:45Z

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/2820497442
❌ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/2820497442
🐛 https://gradle.com/s/si6yr3pol2s7o

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 1 failed, 28 passed, 2 skipped in 33.37s ===================

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-08-08T19:54:11Z

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/2820576711
✅ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/2820576711
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        82      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              355    107    70%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                 1023    247    76%
Name                                                                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------------------------------------------------------
source_file_secure/__init__.py                                                                                  2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/__init__.py       2      0   100%
source_file_secure/source.py                                                                                   45     10    78%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/source.py        50     31    38%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/client.py       256    193    25%
-------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                         355    234    34%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 29 passed, 2 skipped in 44.85s ========================

grubberr · 2022-08-08T20:26:59Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/2820759746

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

bump to 0.2.15

e79c991

github-actions bot added the area/connectors Connector related issues label Aug 8, 2022

octavia-squidington-iii added the connectors/source/file-secure label Aug 8, 2022

girarda requested a review from grubberr August 8, 2022 18:47

girarda marked this pull request as ready for review August 8, 2022 18:47

grubberr approved these changes Aug 8, 2022

View reviewed changes

update requirements

eb351f6

Merge branch 'master' into alex/bumpsecurefileconnector

d2ff3dc

fix SAT

2dc2e62

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr merged commit 719bb60 into master Aug 8, 2022

grubberr deleted the alex/bumpsecurefileconnector branch August 8, 2022 20:45

octavia-squidington-iii mentioned this pull request Aug 10, 2022

Bump Airbyte version from 0.39.42-alpha to 0.40.0-alpha #15493

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Source file-secure: bump to 0.2.15 #15416

Source file-secure: bump to 0.2.15 #15416

Uh oh!

girarda commented Aug 8, 2022

Uh oh!

girarda commented Aug 8, 2022 •

edited by github-actions bot

Loading

Uh oh!

girarda commented Aug 8, 2022 •

edited by github-actions bot

Loading

Uh oh!

girarda commented Aug 8, 2022 •

edited by github-actions bot

Loading

Uh oh!

grubberr commented Aug 8, 2022 •

edited by github-actions bot

Loading

Uh oh!

grubberr commented Aug 8, 2022 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Source file-secure: bump to 0.2.15 #15416

Source file-secure: bump to 0.2.15 #15416

Uh oh!

Conversation

girarda commented Aug 8, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

Uh oh!

girarda commented Aug 8, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

girarda commented Aug 8, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

girarda commented Aug 8, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

Uh oh!

grubberr commented Aug 8, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

grubberr commented Aug 8, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

girarda commented Aug 8, 2022 •

edited by github-actions bot

Loading

girarda commented Aug 8, 2022 •

edited by github-actions bot

Loading

girarda commented Aug 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Aug 8, 2022 •

edited by github-actions bot

Loading