-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add JUnit Test Reports to build outputs. #15271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
79b2c3b
Comment out logging on the test for now as they are very verbose and …
davinchia 705e51f
Test job summary.
davinchia d45fdfc
Format.
davinchia ee0f851
Test.
davinchia 15a38e3
Force fail.
davinchia 5288e45
Test using test reporter action.
davinchia c6bf4a0
Merge branch 'master' into davinchia/remove-unnecessary-test-logging
davinchia a9a7503
Look at the xml test report instead.
davinchia 4a9db01
Merge branch 'davinchia/remove-unnecessary-test-logging' of github.co…
davinchia f66e8d4
This should be false.
davinchia 5ef390d
make this faster.
davinchia aab4585
Force error in a submodule.
davinchia 87c58e9
Only list failed suites.
davinchia 76d89ae
Only list failed tests.
davinchia 4b96c54
Testing for second level test failure detection.
davinchia c53791d
Comment this out to avoid PMD.
davinchia 6518cc4
Does this help the action pick up subfolder test failures?
davinchia 7477215
Add test report generation for all jobs and add fake tests to test this.
davinchia dd6de94
Modify kubernetes test report search path.
davinchia 4ebb4ec
Does spaces mess this up?
davinchia 06fda55
Remove all testing tests.
davinchia d4ece26
Merge branch 'master' into davinchia/remove-unnecessary-test-logging
davinchia e38655f
Remove unused imports.
davinchia 950edbf
Merge branch 'davinchia/remove-unnecessary-test-logging' of github.co…
davinchia 0c6b4f8
Correct paths.
davinchia cecb95b
Merge branch 'master' into davinchia/remove-unnecessary-test-logging
davinchia 972605d
Remove old tee.
davinchia 21c11f6
Merge branch 'davinchia/remove-unnecessary-test-logging' of github.co…
davinchia 0548ccb
Merge branch 'master' into davinchia/remove-unnecessary-test-logging
davinchia 9c2f82f
Do migration tests still fail?
davinchia 089d2ae
Merge branch 'master' into davinchia/remove-unnecessary-test-logging
davinchia d3bbcbb
Remove E2E test to see if this speeds things up.
davinchia ad019a9
Put the test report generation back. Comment out the frontend e2e tes…
davinchia d0ff201
Increase the wait time.
davinchia 3485b80
Remove testing stuff.
davinchia b06eeba
Remove testing stuff.
davinchia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -234,6 +234,15 @@ jobs: | |
- name: Ensure no file change | ||
run: git --no-pager diff && test -z "$(git --no-pager diff)" | ||
|
||
- name: Generate Test Report | ||
uses: dorny/test-reporter@v1 | ||
if: always() | ||
with: | ||
name: Connectors Base Test Report | ||
# Specify top-level and second-level modules. Note there cannot be a space between the comma. | ||
path: '/actions-runner/_work/airbyte/airbyte/*/build/test-results/*/*.xml,/actions-runner/_work/airbyte/airbyte/*/*/build/test-results/*/*.xml' | ||
reporter: java-junit | ||
|
||
# In case of self-hosted EC2 errors, remove this block. | ||
stop-connectors-base-build-runner: | ||
name: "Connectors Base: Stop Build EC2 Runner" | ||
|
@@ -471,7 +480,8 @@ jobs: | |
SUB_BUILD=PLATFORM ./gradlew build javadoc --scan | ||
|
||
- name: Integration test | ||
run: SUB_BUILD=PLATFORM ./gradlew newIntegrationTest | ||
run: | | ||
SUB_BUILD=PLATFORM ./gradlew newIntegrationTest | ||
|
||
- name: Slow integration test | ||
if: contains(github.ref, 'bump-version') || contains(github.ref, 'master') | ||
|
@@ -485,16 +495,25 @@ jobs: | |
if: success() && github.ref == 'refs/heads/master' | ||
run: ./tools/site/link_checker.sh check_docs | ||
|
||
# This is only required on the usual github runner. The usual runner does not contain enough disk space for our use. | ||
# - name: Get Docker Space | ||
# run: docker run --rm busybox df -h | ||
# This is only required on the usual github runner. The usual runner does not contain enough disk space for our use. | ||
# - name: Get Docker Space | ||
# run: docker run --rm busybox df -h | ||
|
||
- name: Run End-to-End Acceptance Tests | ||
run: ./tools/bin/acceptance_test.sh | ||
|
||
- name: Automatic Migration Acceptance Test | ||
run: SUB_BUILD=PLATFORM ./gradlew :airbyte-tests:automaticMigrationAcceptanceTest --scan -i | ||
|
||
- name: Generate Test Report | ||
uses: dorny/test-reporter@v1 | ||
if: always() # run this step even if previous step failed | ||
with: | ||
name: Platform Test Report with Docker E2E Test | ||
# Specify top-level and second-level modules. Note there cannot be a space between the comma. | ||
path: '/actions-runner/_work/airbyte/airbyte/*/build/test-results/*/*.xml,/actions-runner/_work/airbyte/airbyte/*/*/build/test-results/*/*.xml' | ||
reporter: java-junit | ||
|
||
# In case of self-hosted EC2 errors, remove this block. | ||
stop-platform-build-runner: | ||
name: "Platform: Stop Build EC2 Runner" | ||
|
@@ -626,6 +645,14 @@ jobs: | |
run: | | ||
CI=true IS_MINIKUBE=true ./tools/bin/acceptance_test_kube.sh | ||
|
||
- name: Generate Test Report | ||
uses: dorny/test-reporter@v1 | ||
if: always() # run this step even if previous step failed | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. like the note |
||
with: | ||
name: Platform Kubernetes E2E Test Report | ||
path: '/actions-runner/_work/airbyte/airbyte/*/build/test-results/*/*.xml' | ||
reporter: java-junit | ||
|
||
- uses: actions/upload-artifact@v2 | ||
if: failure() | ||
with: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ VERSION=dev TRACKING_STRATEGY=logging USE_STREAM_CAPABLE_STATE=true docker-compo | |
# Sometimes source/dest containers using airbyte volumes survive shutdown, which need to be killed in order to shut down properly. | ||
shutdown_cmd="docker-compose down -v || docker kill \$(docker ps -a -f volume=airbyte_workspace -f volume=airbyte_data -f volume=airbyte_db -q) && docker-compose down -v" | ||
# Uncomment for debugging. Warning, this is verbose. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice add for UX |
||
#trap "echo 'docker-compose logs:' && docker-compose logs -t --tail 1000 && $shutdown_cmd" EXIT | ||
# trap "echo 'docker-compose logs:' && docker-compose logs -t --tail 1000 && $shutdown_cmd" EXIT | ||
|
||
echo "Waiting for services to begin" | ||
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' localhost:8000/api/v1/health)" != "200" ]]; do echo "Waiting for docker deployment.."; sleep 5; done | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really trying to take to heart the idea that we strive to communicate as clearly and loudly as possible when showing developers how to fix their own problems.
is there a name for this test that more clearly screams what it is? How can we get every developer to know there is a better error message process over here?