-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Query and monitor if we have skipped any scheduled jobs #15256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
e31eb19
add error code to ManualOperationResult
xiaohansong ff9b519
fix a bug
xiaohansong f26a0b2
support temporal metrics
xiaohansong f872225
metrics in temporal
xiaohansong 4e651ed
use statsd
xiaohansong f56233a
Merge remote-tracking branch 'origin/master' into xiaohan/goofing
xiaohansong 586aad9
wrap otel config to temporal metric export
xiaohansong 5bf4e67
use http port 4318 for otlp exporter
xiaohansong 33a18f5
simpilfy to support dd only
xiaohansong 85a56d2
use /v1/metrics for endpoint
xiaohansong 43bee0c
use statsd
xiaohansong 1056890
Merge remote-tracking branch 'origin/master' into xiaohan/goofing
xiaohansong 1a113d8
fix
xiaohansong 413cbce
remove unused func
xiaohansong e29815a
wrap up implementation to export temporal metrics to datadog
xiaohansong 0453ac7
use deps.toml to wrap up the dependency
xiaohansong 9d5b795
Merge branch 'master' into xiaohan/goofing
xiaohansong 3666dd5
move to metric client factory
xiaohansong 1eb22dc
Merge remote-tracking branch 'origin/master' into xiaohan/goofing
xiaohansong ac97b12
Merge remote-tracking branch 'origin/master' into xiaohan/goofing
xiaohansong b1d1984
fix pmd error
xiaohansong acf58da
pmd, comment fix
xiaohansong 1b7fbf4
pr comment fix
xiaohansong 12a422b
Merge remote-tracking branch 'origin/master' into xiaohan/goofing
xiaohansong 9cae9bb
add a new metric to observe abnormal scheduled sycns
xiaohansong 4732604
Merge remote-tracking branch 'origin/master' into xiaohan/metricsync
xiaohansong 784ee2a
formatting
xiaohansong 9bdcfb9
add javadoc
xiaohansong 7cb8e08
Merge branch 'master' into xiaohan/metricsync
xiaohansong d3585ce
format fix
xiaohansong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any kind of testing for these queries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in unit test I'm afraid... but I ran these manually on dbeaver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, should we add a comment about what our logic is for determining if a job run was missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense. I have a runbook coming in https://github.com/airbytehq/airbyte-cloud/pull/2272; I'll add a short summary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok perfect, thanks!