Skip to content

Transfer env variable #14936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2022
Merged

Transfer env variable #14936

merged 2 commits into from
Jul 21, 2022

Conversation

benmoriceau
Copy link
Contributor

@benmoriceau benmoriceau commented Jul 21, 2022 •
edited
Loading

What

  • Update the webBackendUpdate new endpoint to filter unselected
  • Properly pass the env to the kube pod
  • restore one line that have been wiped

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jul 21, 2022
@benmoriceau benmoriceau temporarily deployed to more-secrets July 21, 2022 19:31 Inactive
@benmoriceau benmoriceau marked this pull request as ready for review July 21, 2022 21:09
jdpgrailsdev
jdpgrailsdev approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau merged commit 8aa9ab4 into master Jul 21, 2022
@benmoriceau benmoriceau deleted the bmoric/set-env-to-kube-pod branch July 21, 2022 21:46
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@lmossman lmossman Awaiting requested review from lmossman

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server area/worker Related to worker kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmoriceau @jdpgrailsdev