🐛 Source S3: "decimal" type added for parquet #14911

grubberr · 2022-07-21T09:26:57Z

Signed-off-by: Sergey Chvalyuk [email protected]

What

Fix for https://github.com/airbytehq/oncall/issues/326
Customer's data have types which were not supported by source-s3 connector:

physical_type	logical_type
int64	Decimal
fixed_len_byte_array	Decimal
int32	Decimal

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-07-21T09:27:44Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/2710753940
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/2710753940
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
source_s3/source_files_abstract/formats/csv_spec.py                  16      0   100%
source_s3/source_files_abstract/formats/avro_spec.py                  5      0   100%
source_s3/s3file.py                                                  37      0   100%
source_s3/s3_utils.py                                                19      0   100%
source_s3/__init__.py                                                 2      0   100%
source_s3/source.py                                                  29      1    97%
source_s3/source_files_abstract/storagefile.py                       23      1    96%
source_s3/source_files_abstract/formats/abstract_file_parser.py      35      2    94%
source_s3/source_files_abstract/stream.py                           217     14    94%
source_s3/stream.py                                                  43      3    93%
source_s3/source_files_abstract/formats/csv_parser.py                76     18    76%
source_s3/source_files_abstract/file_info.py                         26      8    69%
source_s3/utils.py                                                   31     10    68%
source_s3/source_files_abstract/source.py                            37     14    62%
source_s3/source_files_abstract/spec.py                              43     22    49%
source_s3/source_files_abstract/formats/avro_parser.py               38     25    34%
source_s3/source_files_abstract/formats/parquet_parser.py            61     44    28%
-------------------------------------------------------------------------------------
TOTAL                                                               747    162    78%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_s3/source_files_abstract/storagefile.py                       23      0   100%
source_s3/source_files_abstract/spec.py                              43      0   100%
source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
source_s3/source_files_abstract/formats/csv_spec.py                  16      0   100%
source_s3/source_files_abstract/formats/avro_spec.py                  5      0   100%
source_s3/source_files_abstract/formats/abstract_file_parser.py      35      0   100%
source_s3/source.py                                                  29      0   100%
source_s3/s3file.py                                                  37      0   100%
source_s3/s3_utils.py                                                19      0   100%
source_s3/__init__.py                                                 2      0   100%
source_s3/source_files_abstract/formats/parquet_parser.py            61      1    98%
source_s3/stream.py                                                  43      1    98%
source_s3/source_files_abstract/source.py                            37      2    95%
source_s3/source_files_abstract/formats/avro_parser.py               38      3    92%
source_s3/source_files_abstract/file_info.py                         26      3    88%
source_s3/source_files_abstract/stream.py                           217     36    83%
source_s3/source_files_abstract/formats/csv_parser.py                76     18    76%
source_s3/utils.py                                                   31      8    74%
-------------------------------------------------------------------------------------
TOTAL                                                               747     72    90%

Build Passed

Test summary info:

All Passed

Signed-off-by: Sergey Chvalyuk <[email protected]>

pedroslopez

Nice! Confirmed that this fixes the we were seeing with FIXED_LEN_BYTE_ARRAY types

grubberr · 2022-07-21T21:29:49Z

/publish connector=connectors/source-s3

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/2714823670

Connector	Did it publish?	Were definitions generated?
connectors/source-s3	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

decimal added for parquet

2507f21

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added the area/connectors Connector related issues label Jul 21, 2022

octavia-squidington-iii added the connectors/source/s3 label Jul 21, 2022

s3.md updated

f1826fa

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added the area/documentation Improvements or additions to documentation label Jul 21, 2022

grubberr requested a review from arsenlosenko July 21, 2022 10:16

grubberr self-assigned this Jul 21, 2022

arsenlosenko approved these changes Jul 21, 2022

View reviewed changes

grubberr added the team/connectors-python label Jul 21, 2022

wqMerge branch 'master' into grubberr/oncall-326-source-s3

d1ae730

grubberr requested a review from sherifnada July 21, 2022 12:00

pedroslopez approved these changes Jul 21, 2022

View reviewed changes

auto-bump connector version [ci skip]

45e618f

grubberr merged commit 29d6a61 into master Jul 21, 2022

grubberr deleted the grubberr/oncall-326-source-s3 branch July 21, 2022 22:04

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source S3: "decimal" type added for parquet #14911

🐛 Source S3: "decimal" type added for parquet #14911

grubberr commented Jul 21, 2022 •

edited

Loading

grubberr commented Jul 21, 2022 •

edited by github-actions bot

Loading

pedroslopez left a comment

grubberr commented Jul 21, 2022 •

edited by github-actions bot

Loading

🐛 Source S3: "decimal" type added for parquet #14911

🐛 Source S3: "decimal" type added for parquet #14911

Conversation

grubberr commented Jul 21, 2022 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Jul 21, 2022 • edited by github-actions bot Loading

Build Passed

pedroslopez left a comment

Choose a reason for hiding this comment

grubberr commented Jul 21, 2022 • edited by github-actions bot Loading

grubberr commented Jul 21, 2022 •

edited

Loading

grubberr commented Jul 21, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 21, 2022 •

edited by github-actions bot

Loading