Best Practices PMD rules #14904
Merged
Best Practices PMD rules #14904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
alovew
force-pushed
the
anne/best-practices-pmd-3
branch
from
608c6c1 to
6f0fdd3
Compare
alovew
commented
Jul 21, 2022
| if (metricClient != null) { | ||
| throw new RuntimeException("You cannot initialize configuration more than once."); | ||
| } | ||
|
|
||
| if (configs.getMetricClient().equals(DATADOG_METRIC_CLIENT)) { | ||
| if (DATADOG_METRIC_CLIENT.equals(configs.getMetricClient())) { |
There was a problem hiding this comment.
actually saw a bug in dev recently due to this, so this is good to fix.
alovew
commented
Jul 21, 2022
| LOGGER.warn("Failed to successfully notify auto-disable connection warning: {}", notification); | ||
| } | ||
|
|
||
| if (FAILURE_NOTIFICATION == action) { |
There was a problem hiding this comment.
looking at this again, thinking maybe I should use a default and log something like "unknown action"?
alovew
commented
Jul 21, 2022
| case STDERR -> LOGGER.error(message); | ||
| // assumption that this is an empty frame that connotes the container exiting. | ||
| case END -> LOGGER.error(service + " stopped!!!"); | ||
| // default includes STDOUT and anything else | ||
| default -> LOGGER.info(message); |
There was a problem hiding this comment.
opinions on setting this as the default?
There was a problem hiding this comment.
That seems fine. Worst case scenario is that we get a few extra cases logged to INFO.
alovew
commented
Jul 21, 2022
| case DEBUG -> logger.debug(logMessage.getMessage()); | ||
| case TRACE -> logger.trace(logMessage.getMessage()); | ||
| default -> logger.info(logMessage.getMessage()); |
There was a problem hiding this comment.
opinions on this default? (similar to above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following Best Practices PMD rules:
LiteralsFirstInComparisons
LooseCoupling
PreserveStackTrace
SwitchStmtsShouldHaveDefault
SystemPrintln
UseCollectionIsEmpty
UseVarargs