Skip to content

Mysql source: test utf8 char in json column #14865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2022
Merged

Mysql source: test utf8 char in json column #14865

merged 2 commits into from
Jul 20, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jul 20, 2022 •
edited
Loading

What

🚨 User Impact 🚨

  • None.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 20, 2022
@tuliren tuliren mentioned this pull request Jul 20, 2022
Closed
@tuliren
Copy link
Contributor Author

tuliren commented Jul 20, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/2702041932
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/2702041932
No Python unittests run

Build Passed

Test summary info:

All Passed

@tuliren tuliren marked this pull request as ready for review July 20, 2022 04:21
@tuliren tuliren requested a review from a team as a code owner July 20, 2022 04:21
@tuliren
Copy link
Contributor Author

tuliren commented Jul 20, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/2706261314
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/2706261314
No Python unittests run

Build Passed

Test summary info:

All Passed

@tuliren tuliren merged commit 07b1329 into master Jul 20, 2022
@tuliren tuliren deleted the liren/test-mysql-json-utf8 branch July 20, 2022 17:55
edgao
edgao reviewed Jul 20, 2022
View reviewed changes
...t-integration/java/io/airbyte/integrations/source/mysql/AbstractMySqlSourceDatatypeTest.java
.addInsertValues("null", "'{\"a\": 10, \"b\": 15}'")
.addExpectedValues(null, "{\"a\": 10, \"b\": 15}")
.addInsertValues("null", "'{\"a\": 10, \"b\": 15}'", "'{\"fóo\": \"bär\"}'", "'{\"春江潮水连海平\": \"海上明月共潮生\"}'")
.addExpectedValues(null, "{\"a\": 10, \"b\": 15}", "{\"fóo\": \"bär\"}", "{\"春江潮水连海平\": \"海上明月共潮生\"}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 ❤️

mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022
@tuliren @mfsiega-airbyte
Mysql source: test utf8 char in json column (#14865)
a3131e8 
* Add test case in mysql data type

* Add one more test case for utf8 char
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UTF-8 parsing issue with MySQL native JSON columns
3 participants
@tuliren @edgao @octavia-squidington-iii