-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix build: update connector command worker output usage in tests #14859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test connector=connectors/destination-mysql
Build FailedTest summary info:
|
/test connector=connectors/source-postgres
Build PassedTest summary info:
|
/test connector=connectors/destination-mysql
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, MySQL test failure looks unrelated but probably worth waiting for test rerun just in case
What
#14715 changed the output type of our connector command workers to be
ConnectorJobOutput
, which broke the Connectors Base /standard-source-test
/standard-destination-test
build (see failure example here)How
Fix the build by considering this new output and getting the right type from it for each job.