Skip to content

fix build: update connector command worker output usage in tests #14859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Jul 19, 2022

What

#14715 changed the output type of our connector command workers to be ConnectorJobOutput, which broke the Connectors Base / standard-source-test / standard-destination-test build (see failure example here)

How

Fix the build by considering this new output and getting the right type from it for each job.

@pedroslopez pedroslopez marked this pull request as ready for review July 19, 2022 23:22
@pedroslopez
Copy link
Contributor Author

pedroslopez commented Jul 19, 2022

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2701281639
❌ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2701281639
🐛 https://gradle.com/s/dizuukk4ti6k2

Build Failed

Test summary info:

Could not find result summary

@pedroslopez
Copy link
Contributor Author

pedroslopez commented Jul 19, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2701288767
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2701288767
No Python unittests run

Build Passed

Test summary info:

All Passed

@edgao edgao mentioned this pull request Jul 19, 2022
@pedroslopez pedroslopez changed the title fix: update connector command worker output usage fix build: update connector command worker output usage in tests Jul 20, 2022
@pedroslopez
Copy link
Contributor Author

pedroslopez commented Jul 20, 2022

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2701483379
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2701483379
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

@pedroslopez pedroslopez requested a review from edgao July 20, 2022 00:38
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, MySQL test failure looks unrelated but probably worth waiting for test rerun just in case

@pedroslopez pedroslopez merged commit c0bc170 into master Jul 20, 2022
@pedroslopez pedroslopez deleted the pedroslopez/fix-standard-source-test branch July 20, 2022 01:16
mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022
)

* fix: update connector command worker output usage

* fix standard-destination-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants