Skip to content

Update the workflow being replayed #14855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

benmoriceau
Copy link
Contributor

What

Update the workflow being replayed.

The workflow history we are replaying is very old and can hide some potential version issue like what happened here.

This review is updating the history with a recent workflow that ran in prod.

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jul 19, 2022
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - gotta keep that test data fresh.

Can you share how you got this workflow data? Did you just download it from the Temporal UI?

Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 is this something that should be done any time a new version is introduced?
Also, is there any value in keeping tests with old histories to ensure they still pass?

@benmoriceau
Copy link
Contributor Author

Nice - gotta keep that test data fresh.

Can you share how you got this workflow data? Did you just download it from the Temporal UI?

@evantahler Yes I downloaded it from there. There is a download button on the top right of this interface.

@benmoriceau
Copy link
Contributor Author

👍🏻 is this something that should be done any time a new version is introduced?
Also, is there any value in keeping tests with old histories to ensure they still pass?

Ideally yes, that will allow to avoid issue like the one you faced. We didn't enforce it so far and the test suite is not complete (doesn't include any failure or cancel or reset...)

@benmoriceau benmoriceau merged commit 760a92d into master Jul 20, 2022
@benmoriceau benmoriceau deleted the bmoric/update-replayer-test branch July 20, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants