🐛 Source Facebook Marketing: Fix since cannot be in the future in time_range error #14831

lazebnyi · 2022-07-19T12:39:37Z

What

https://github.com/airbytehq/oncall/issues/345 - Source Facebook Marketing: since cannot be in the future in time_range error

How

Added future date validation (if validation failed raised FutureDateException).

Pre-merge Checklist

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

lazebnyi · 2022-07-19T12:40:37Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2697697951
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2697697951
🐛 https://gradle.com/s/34ugxt6vyctla

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_ok
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_end_date_before_start_date
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_exception
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_streams
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_update_insights_streams
	 �[31m========================= �[31m�[1m5 failed�[0m, �[32m93 passed�[0m�[31m in 1.48s�[0m�[31m =========================�[0m

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2697697951
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2697697951
🐛 https://gradle.com/s/mdixj3ggvnyk4

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_ok
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_end_date_before_start_date
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_exception
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_streams
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_update_insights_streams
	 �[31m========================= �[31m�[1m5 failed�[0m, �[32m93 passed�[0m�[31m in 1.40s�[0m�[31m =========================�[0m

lazebnyi · 2022-07-19T16:09:51Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2699026262
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2699026262
🐛 https://gradle.com/s/wmpqbtoclve2i

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_ok
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_end_date_before_start_date
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_check_connection_exception
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_streams
	 FAILED unit_tests/test_source.py::TestSourceFacebookMarketing::test_update_insights_streams
	 �[31m========================= �[31m�[1m5 failed�[0m, �[32m93 passed�[0m�[31m in 1.33s�[0m�[31m =========================�[0m

lazebnyi · 2022-07-20T12:06:21Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2704592506
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2704592506
🐛 https://gradle.com/s/4s6jkhk5pplu4

Build Failed

Test summary info:

Could not find result summary

…cannot-be-in-the-future-in-time_range-error

lazebnyi · 2022-07-20T12:08:41Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2704605884
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2704605884
🐛 https://gradle.com/s/emrtaboa6gvc4

Build Failed

Test summary info:

Could not find result summary

…cannot-be-in-the-future-in-time_range-error

lazebnyi · 2022-07-20T17:48:47Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2706631995
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2706631995
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/spec.py                              50      2    96%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             128     27    79%
source_facebook_marketing/streams/common.py                    40     13    68%
source_facebook_marketing/streams/streams.py                  113     44    61%
source_facebook_marketing/streams/base_insight_streams.py     132     54    59%
source_facebook_marketing/source.py                            39     16    59%
source_facebook_marketing/utils.py                             14      6    57%
source_facebook_marketing/streams/async_job.py                210    134    36%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                         904    368    59%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                210      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    40      1    98%
source_facebook_marketing/source.py                            39      1    97%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/spec.py                              50      2    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     132     13    90%
source_facebook_marketing/streams/streams.py                  113     26    77%
source_facebook_marketing/streams/base_streams.py             128     30    77%
source_facebook_marketing/utils.py                             14      6    57%
-------------------------------------------------------------------------------
TOTAL                                                         904     91    90%

Build Passed

Test summary info:

All Passed

…cannot-be-in-the-future-in-time_range-error

lazebnyi · 2022-07-22T11:44:40Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2718358740

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

lazebnyi added 2 commits July 19, 2022 15:32

Fix since cannot be in the future in time_range error

cee65ed

Changed start_date in invalid_config

bc6480e

lazebnyi requested review from grubberr and arsenlosenko July 19, 2022 12:39

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 19, 2022

octavia-squidington-iii added the connectors/source/facebook-marketing label Jul 19, 2022

arsenlosenko approved these changes Jul 19, 2022

View reviewed changes

Updated date to timestamp in validatior

0775bb9

Merge branch 'master' into lazebnyi/345-facebook-marketing-fix-since-…

8c78b8f

…cannot-be-in-the-future-in-time_range-error

lazebnyi and others added 3 commits July 20, 2022 18:49

Fix linter error

92bb76f

Merge branch 'master' into lazebnyi/345-facebook-marketing-fix-since-…

f8ef94a

…cannot-be-in-the-future-in-time_range-error

Merged master to branch

b5d5b34

lazebnyi and others added 3 commits July 22, 2022 14:17

Merge branch 'master' into lazebnyi/345-facebook-marketing-fix-since-…

b632534

…cannot-be-in-the-future-in-time_range-error

Bumped docker version

e8b2052

Merged master to branch

6b7b785

lazebnyi marked this pull request as ready for review July 22, 2022 11:20

grubberr approved these changes Jul 22, 2022

View reviewed changes

auto-bump connector version [ci skip]

e36ceaf

lazebnyi merged commit e8a7691 into master Jul 22, 2022

lazebnyi deleted the lazebnyi/345-facebook-marketing-fix-since-cannot-be-in-the-future-in-time_range-error branch July 22, 2022 13:06

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Facebook Marketing: Fix since cannot be in the future in time_range error #14831

🐛 Source Facebook Marketing: Fix since cannot be in the future in time_range error #14831

lazebnyi commented Jul 19, 2022

lazebnyi commented Jul 19, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 19, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 22, 2022 •

edited by github-actions bot

Loading

🐛 Source Facebook Marketing: Fix since cannot be in the future in time_range error #14831

🐛 Source Facebook Marketing: Fix since cannot be in the future in time_range error #14831

Conversation

lazebnyi commented Jul 19, 2022

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

lazebnyi commented Jul 19, 2022 • edited by github-actions bot Loading

Build Failed

Build Failed

lazebnyi commented Jul 19, 2022 • edited by github-actions bot Loading

Build Failed

lazebnyi commented Jul 20, 2022 • edited by github-actions bot Loading

Build Failed

lazebnyi commented Jul 20, 2022 • edited by github-actions bot Loading

Build Failed

lazebnyi commented Jul 20, 2022 • edited by github-actions bot Loading

Build Passed

lazebnyi commented Jul 22, 2022 • edited by github-actions bot Loading

lazebnyi commented Jul 19, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 19, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Jul 22, 2022 •

edited by github-actions bot

Loading