Skip to content

change jdbc clickhoue verstion into 0.3.2-patch9 #14820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2022
Merged

change jdbc clickhoue verstion into 0.3.2-patch9 #14820

merged 3 commits into from
Jul 19, 2022

Conversation

grishick
Copy link
Contributor

Created a non-forked version of this PR to run CI

@grishick grishick requested a review from a team as a code owner July 19, 2022 00:34
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 19, 2022
@grishick grishick temporarily deployed to more-secrets July 19, 2022 00:35 Inactive
ryankfu
ryankfu approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ryankfu ryankfu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I see the old PR the community member did was about a month and half old so it seems that Clickhouse has updated to 0.3.2-patch10. I would consider upgrading to the newest version since it appears we don't have any specific reason not to unless I'm mistaken: https://github.com/ClickHouse/clickhouse-jdbc/releases/tag/v0.3.2-patch10

@grishick grishick temporarily deployed to more-secrets July 19, 2022 15:51 Inactive
@grishick grishick mentioned this pull request Jul 19, 2022
Merged
37 tasks
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 19, 2022
@grishick grishick temporarily deployed to more-secrets July 19, 2022 16:16 Inactive
@grishick
Copy link
Contributor Author

grishick commented Jul 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2699455856
❌ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2699455856
🐛 https://gradle.com/s/4vdwkuawlypi4

Build Failed

Test summary info:

Could not find result summary

ryankfu
ryankfu reviewed Jul 19, 2022
View reviewed changes
docs/integrations/destinations/clickhouse.md
@@ -79,8 +79,9 @@ Therefore, Airbyte ClickHouse destination will create tables and schemas using t

| Version | Date | Pull Request | Subject |
|:--------|:-----------| :--- |:---------------------------------------------|
| 0.1.8 | 2022-07-05 | [\#13516](https://github.com/airbytehq/airbyte/pull/13516) | Added JDBC default parameter socket timeout |
| 0.1.7 | 2022-06-16 | [\#13852](https://github.com/airbytehq/airbyte/pull/13852) | Updated stacktrace format for any trace message errors |
| 0.1.10 | 2022-07-05 | [\#13639](https://github.com/airbytehq/airbyte/pull/13639) | Change JDBC ClickHouse version into 0.3.2-patch9 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason we jump to 0.1.10 to have parity between non strict-encrypt and strict-encrypt versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@grishick
Copy link
Contributor Author

grishick commented Jul 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2700120365

@grishick grishick temporarily deployed to more-secrets July 19, 2022 19:50 Inactive
@grishick
Copy link
Contributor Author

grishick commented Jul 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2700327339
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2700327339
No Python unittests run

Build Passed

Test summary info:

All Passed

grishick added 2 commits July 19, 2022 13:34
bump versions of Destination Clickhouse
c63e171 
Align Destination Clickhouse  and strict encrypt versions
Fix for multi-statement queries
2a9aa31
@grishick
Copy link
Contributor Author

grishick commented Jul 19, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse,connectors/destination-clickhouse-strict-encrypt

🕑 Publishing the following connectors:
connectors/destination-clickhouse,connectors/destination-clickhouse-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/2700464867


Connector Did it publish? Were definitions generated?
connectors/destination-clickhouse ✅ ✅
connectors/destination-clickhouse-strict-encrypt ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick
Copy link
Contributor Author

grishick commented Jul 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2700892389
❌ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2700892389
🐛 https://gradle.com/s/mtp6dmqtlnyni

Build Failed

Test summary info:

Could not find result summary

@grishick grishick merged commit b406317 into master Jul 19, 2022
@grishick grishick deleted the ClickHouse-0.3.2 branch July 19, 2022 22:32
mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022
@grishick @mfsiega-airbyte
change jdbc clickhoue verstion into 0.3.2-patch9 (#14820)
e365370 
* bump versions of Destination Clickhouse
* Align Destination Clickhouse  and strict encrypt versions

Co-authored-by: Octavia Squidington III <[email protected]> and @mzitnik
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankfu ryankfu ryankfu approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grishick @ryankfu @octavia-squidington-iii