SAT: add test case to check supported_sync_modes
field is not empty
#14800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closing #13027
Pydantic is already validating that the list of
supported_sync_modes
contains onlyfull_refresh
or/andincremental
but this field is not declared as required (it's a TODO).Before attempting a protocol change, SAT can ensure this rule is enforced.
I don't think this will solve https://github.com/airbytehq/airbyte-internal-issues/issues/587 as the
source-e2e-test
is a java connector. @pedroslopez do you confirm I can't run SAT on a java source?How
Add a test to check that all streams defined in a catalog have the
supported_sync_modes
field set to a nonempty list.NB: I added some Pytest syntactic sugar to lighten the conditional raise in the unit test with the
does_not_raise
context.🚨 User Impact 🚨
All connector builds that are not passing this new test will fail.