Skip to content

Fix build #14799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix build #14799

merged 1 commit into from
Jul 18, 2022

Conversation

benmoriceau
Copy link
Contributor

What

Fix build

Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau temporarily deployed to more-secrets July 18, 2022 16:29 Inactive
@benmoriceau benmoriceau merged commit 6d81a75 into master Jul 18, 2022
@benmoriceau benmoriceau deleted the bmoric/fix-master branch July 18, 2022 16:44
@evantahler
Copy link
Contributor

finally 😝

@@ -594,6 +595,7 @@ private WebBackendConnectionUpdate getUpdateInput(final ConnectionRead connectio
}

// can be helpful for debugging
@SuppressWarnings("PMD")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is already merged but could we just suppress the specific PMD failure instead of all of PMD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants