Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce, source-s3 #14791

grubberr · 2022-07-18T10:59:37Z

Signed-off-by: Sergey Chvalyuk [email protected]

Connectors:

source-google-ads
source-instagram
source-salesforce
source-s3

What

Change deprecated AirbyteLogger() -> logging.getLogger("airbyte") for integration_tests
because logging.getLogger("airbyte") returns new logger which supports extra kwargs

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-07-18T10:59:56Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2689996823
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2689996823
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 163     26    84%
source_google_ads/source.py                   80     23    71%
source_google_ads/custom_query_stream.py      75     46    39%
--------------------------------------------------------------
TOTAL                                        406    105    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 163      8    95%
source_google_ads/source.py                   80      4    95%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68     12    82%
--------------------------------------------------------------
TOTAL                                        406     30    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 638.26s (0:10:38) ===================

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-07-18T11:13:26Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/2690087891
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/2690087891
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        38     11    71%
source_instagram/streams.py      207     90    57%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            342    128    63%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/source.py        38      1    97%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      207     23    89%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            342     34    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 263.03s (0:04:23) ===================

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-07-18T11:59:40Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2690333734
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2690333734
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               150     19    87%
source_salesforce/streams.py           307     67    78%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             77     33    57%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  574    133    77%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             77      6    92%
source_salesforce/api.py               150     14    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
source_salesforce/streams.py           307     43    86%
--------------------------------------------------------
TOTAL                                  574     67    88%

Build Passed

Test summary info:

All Passed

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-07-18T14:08:30Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/2691145647
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/2691145647
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
source_s3/source_files_abstract/formats/csv_spec.py                  16      0   100%
source_s3/source_files_abstract/formats/avro_spec.py                  5      0   100%
source_s3/s3file.py                                                  37      0   100%
source_s3/s3_utils.py                                                19      0   100%
source_s3/__init__.py                                                 2      0   100%
source_s3/source.py                                                  29      1    97%
source_s3/source_files_abstract/storagefile.py                       23      1    96%
source_s3/source_files_abstract/formats/abstract_file_parser.py      35      2    94%
source_s3/source_files_abstract/stream.py                           217     14    94%
source_s3/stream.py                                                  43      3    93%
source_s3/source_files_abstract/formats/csv_parser.py                76     18    76%
source_s3/source_files_abstract/file_info.py                         26      8    69%
source_s3/utils.py                                                   31     10    68%
source_s3/source_files_abstract/source.py                            37     14    62%
source_s3/source_files_abstract/spec.py                              43     22    49%
source_s3/source_files_abstract/formats/avro_parser.py               38     25    34%
source_s3/source_files_abstract/formats/parquet_parser.py            61     44    28%
-------------------------------------------------------------------------------------
TOTAL                                                               747    162    78%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_s3/source_files_abstract/storagefile.py                       23      0   100%
source_s3/source_files_abstract/spec.py                              43      0   100%
source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
source_s3/source_files_abstract/formats/csv_spec.py                  16      0   100%
source_s3/source_files_abstract/formats/avro_spec.py                  5      0   100%
source_s3/source_files_abstract/formats/abstract_file_parser.py      35      0   100%
source_s3/source.py                                                  29      0   100%
source_s3/s3file.py                                                  37      0   100%
source_s3/s3_utils.py                                                19      0   100%
source_s3/__init__.py                                                 2      0   100%
source_s3/source_files_abstract/formats/parquet_parser.py            61      1    98%
source_s3/stream.py                                                  43      1    98%
source_s3/source_files_abstract/source.py                            37      2    95%
source_s3/source_files_abstract/formats/avro_parser.py               38      3    92%
source_s3/source_files_abstract/file_info.py                         26      3    88%
source_s3/source_files_abstract/stream.py                           217     36    83%
source_s3/source_files_abstract/formats/csv_parser.py                76     18    76%
source_s3/utils.py                                                   31      8    74%
-------------------------------------------------------------------------------------
TOTAL                                                               747     72    90%

Build Passed

Test summary info:

All Passed

grubberr · 2022-07-18T14:56:06Z

@brianjlai I decided to create less code PR (then this #14780)
to fix logger problem for specific connectors

brianjlai

change looks good!

fix logger for source-google-ads

df83c19

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added the area/connectors Connector related issues label Jul 18, 2022

octavia-squidington-iii added the connectors/source/google-ads label Jul 18, 2022

fix logger for source-instagram

e2cd66b

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr changed the title ~~Connectors: Fix AirbyteLogger() for source-google-ads~~ Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram Jul 18, 2022

octavia-squidington-iii added the connectors/source/instagram label Jul 18, 2022

grubberr added the team/connectors-python label Jul 18, 2022

grubberr self-assigned this Jul 18, 2022

fix logger for source-salesforce

5bde547

Signed-off-by: Sergey Chvalyuk <[email protected]>

octavia-squidington-iii added the connectors/source/salesforce label Jul 18, 2022

grubberr changed the title ~~Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram~~ Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce Jul 18, 2022

grubberr requested a review from lazebnyi July 18, 2022 14:01

fix logger for source-s3

eef3da7

Signed-off-by: Sergey Chvalyuk <[email protected]>

octavia-squidington-iii added the connectors/source/s3 label Jul 18, 2022

grubberr changed the title ~~Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce~~ Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce, source-s3 Jul 18, 2022

grubberr requested a review from brianjlai July 18, 2022 14:49

lazebnyi approved these changes Jul 18, 2022

View reviewed changes

grubberr requested a review from evantahler July 18, 2022 18:44

brianjlai approved these changes Jul 19, 2022

View reviewed changes

grubberr merged commit e73f79c into master Jul 19, 2022

grubberr deleted the grubberr/change-deprecated-logger-2 branch July 19, 2022 08:45

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

grubberr mentioned this pull request Aug 6, 2022

Connectors: AirbyteLogger() -> logging.getLogger("airbyte") #14780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce, source-s3 #14791

Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce, source-s3 #14791

grubberr commented Jul 18, 2022 •

edited

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022

brianjlai left a comment

Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce, source-s3 #14791

Connectors: Fix AirbyteLogger() for source-google-ads, source-instagram, source-salesforce, source-s3 #14791

Conversation

grubberr commented Jul 18, 2022 • edited Loading

Connectors:

What

grubberr commented Jul 18, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 18, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 18, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 18, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 18, 2022

brianjlai left a comment

Choose a reason for hiding this comment

grubberr commented Jul 18, 2022 •

edited

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 18, 2022 •

edited by github-actions bot

Loading