-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Align strict-encrypt connector version with the actual connector #14775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, I always forget these variants exist.
I can't find the specifics, but didn't liren/davin make this process better during hackdays?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we talked about this but currently the build process doesn't allow for multiple updates to the several Dockerfiles at once, right?
I remember this was my assignment from yesterday so that's my fault I dropped the ball. It's definitely a hassle to have to make multiple PRs when I can definitely see this as an auto generated from from the general database version or would that cause issues because it would be important to separate the versioning?
I don't think their project is finished yet |
ultimately, we want to get rid of these "***-strict-encrypt" connectors in favor of a solution that @tuliren and @davinchia came up with during the last hackathon |
c377df1
to
49b15c1
Compare
/publish connector=destination-oracle-strict-encrypt run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/destination-oracle-strict-encrypt run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Change the version of destination-oracle-strict-encrypt to match the version of destination-oracle connector