Apply Best Practices PMD rules #14753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
alovew
force-pushed
the
anne/best-practices-pmd
branch
from
276f783 to
659ec94
Compare
cgardens
approved these changes
Jul 15, 2022
evantahler
approved these changes
Jul 15, 2022
alovew
force-pushed
the
anne/best-practices-pmd
branch
from
bba7962 to
e981ead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the following PMD rules and fixes existing violations:
Where you see variables & methods removed, it is because they are not used. There is a little bit of a gotcha in this for cases where there is an unused variable, but the assignment of the variable itself has side effects (like a database delete/create). In these cases, just the variable assignment is removed.