🪟 🎉 Add experimentation support to auth pages #14650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
reviewed
Jul 13, 2022
| @@ -39,7 +59,11 @@ const Auth: React.FC = () => { | |||
| </FormContent> | |||
| </div> | |||
| <div className={styles.rightSide}> | |||
| <PersonQuoteCover /> | |||
| {hasValidRightSideUrl(rightSideUrl) ? ( | |||
| <iframe src={rightSideUrl} title="Right Side" scrolling="no" /> | |||
There was a problem hiding this comment.
Since the title might be read out by assistive technology, I would suggest we change this to something that gives a bit more hint about the iframe's content, e.g. Why you should use Airbyte or Benefits of using Airbyte. Also I think we should ideally i18n this string.
edmundito
force-pushed
the
edmundito/signup-experiment-support
branch
from
be8dfe4 to
9375b5c
Compare
timroes
reviewed
Jul 14, 2022
| @@ -18,4 +18,11 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| justify-content: space-between; | |||
|
|
|||
| > iframe { | |||
There was a problem hiding this comment.
🎨 Nitpick: Could we give the iFrame a className as well, to not need to work with tag selectors here?
timroes
force-pushed
the
edmundito/signup-experiment-support
branch
from
b56dddd to
0e277c6
Compare
timroes
reviewed
Jul 14, 2022
Comment on lines
+14
to
+19
| const getExperiment: ExperimentService["getExperiment"] = (key): any => { | ||
| if (key === TEST_EXPERIMENT_KEY) { | ||
| return { test: 13 }; | ||
| } | ||
| throw new Error(`${key} not mocked for testing`); | ||
| }; |
There was a problem hiding this comment.
@edmundito I pushed a small change to this, so the method is throwing for not implemented ones, which helps us catch it more reliable during a test if it would ever be called with a different key. (Also helps us getting rid of one any ;) )
…ytehq/airbyte into edmundito/signup-experiment-support
timroes
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #13063
Adds the ability to experiment with the auth pages, most notably the sign up page:
How
For the most part, the text experiments can be enabled by changing the i18n strings. The Signup button has been given a unique string id so that it doesn't override titles or other uses on the button on other pages (like the email invitation page.)
For the side panel URL, it renders an iframe with the page. The page is limited to the airbyte domain and must be https. Otherwise, there will be an error.
For the self-hosted CTA (aka
<GitBlock />) it just adds a boolean that can be controlled from LaunchDarkly to hide it.Finally, the customizations for
<PersonQuoteCover />have been removed.Recommended reading order
Top to bottom
Tests